pedromsantos/glenn

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('multiple pitches after 1 repeat go down an octave on descending lines', () => {
      const line = new PitchLine(
        [Pitch.C, Pitch.D, Pitch.E, Pitch.C, Pitch.B],
        PitchLineDirection.Descending
      );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('multiple pitches after 1 repeat go up an octave on ascending lines', () => {
      const line = new PitchLine(
        [Pitch.C, Pitch.D, Pitch.E, Pitch.C, Pitch.D],
        PitchLineDirection.Ascending
      );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test('multiple pitches when repeated go up an octave on ascending lines', () => {
      const line = new PitchLine(
        [Pitch.C, Pitch.D, Pitch.E, Pitch.C],
        PitchLineDirection.Ascending
      );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test('multiple pitches when repeated stay on same octave on neutral lines', () => {
      const line = new PitchLine([Pitch.C, Pitch.D, Pitch.E, Pitch.C], PitchLineDirection.Neutral);

      const melodicLine = line.melodicLine(Octave.C4, Duration.Eighth);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test('multiple pitches when repeated go down an octave on descending lines', () => {
      const line = new PitchLine(
        [Pitch.C, Pitch.D, Pitch.E, Pitch.C],
        PitchLineDirection.Descending
      );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('2 dotted quarter notes and a quarter note fill it', () => {
      expect(
        measure
          .add(new Note(Pitch.C, Duration.DottedQuarter, Octave.C1))
          .add(new Note(Pitch.C, Duration.DottedQuarter, Octave.C2))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('4 quarter notes fill it', () => {
      expect(
        measure
          .add(new Note(Pitch.C, Duration.Quarter, Octave.C1))
          .add(new Note(Pitch.C, Duration.Quarter, Octave.C2))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  test('should go up in frequency', () => {
    expect(Octave.C0.up().up().up().up().up().up().up().up().up()).toBe(Octave.C8);
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  test('should go down in frequency', () => {
    expect(Octave.C8.down().down().down().down().down().down().down().down().down()).toBe(
      Octave.C0
    );
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const lines = new BarryHarrisLine(scale)
        .arpeggioUpFrom(ScaleDegree.I)
        .resolveTo(Pitch.D)
        .scaleDownFromLastPitchTo(ScaleDegree.III)
        .arpeggioUpFromLastPitch()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        const line = new BarryHarrisLine(scale)
          .arpeggioUpFrom(ScaleDegree.I)
          .resolveTo(Pitch.D)
          .scaleDownFromLastPitchTo(ScaleDegree.III)
          .arpeggioUpFromLastPitch()

• Read up
  Read up

File Barry.test.ts has 267 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { BarryHarrisLine } from '../../Domain/Barry';
import { Duration } from '../../Domain/Duration';
import { GuitarPitchLines, Position, Tab } from '../../Domain/Guitar';
import { Octave } from '../../Domain/Note';
import { Pitch } from '../../Domain/Pitch';

Function executeCommand has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  executeCommand(command: BarryHarrisCommand) {
    switch (command.command) {
      case 'ArpeggioUpFrom':
        this.line.arpeggioUpFrom(command.degree);
        break;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  accidentals: -6 | -5 | -4 | -3 | -2 | -1 | 0 | 1 | 2 | 3 | 4 | 5 | 6;

• Read up
  Read up

Function scaleDownExtraHalfSteps has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  scaleDownExtraHalfSteps(to: ScaleDegree, from: ScaleDegree) {
    let rawLine = this.scale.down(from, to);

    if (this.lineStartsAtChordTone(from)) {
      rawLine = rawLine.insertHalfToneBetween(

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scaleDownExtraHalfStepsFromLastPitch(to: ScaleDegree) {
    const from = this.lastDegree();

    if (from) {
      this.scaleDownExtraHalfSteps(to, from - 1);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scaleDownFromLastPitchTo(to: ScaleDegree) {
    const from = this.lastDegree();

    if (from) {
      this.scaleDown(to, from - 1);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

export class AbcDuration {
  constructor(private readonly duration: DurationPrimitives) {}

  toString() {
    return `L:${this.duration.fraction}`;

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

export class AbcMeter {
  constructor(private readonly timeSignature: TimeSignaturePrimitives) {}

  toString() {
    return `M:${this.timeSignature.signature}`;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    return new ClosedChord(
      chordPitches.pitchForFunction(ChordFunction.Root),
      ChordPattern.patternFor(chordPitches.toIntervals()) ?? ChordPattern.Major7,
      Duration.Whole,
      Octave.C4

• Read up
  Read up