pedromsantos/glenn

View on GitHub

Showing 3 of 462 total issues

File Barry.test.ts has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { BarryHarrisLine } from '../../Domain/Barry';
import { Duration } from '../../Domain/Duration';
import { GuitarPitchLines, Position, Tab } from '../../Domain/Guitar';
import { Octave } from '../../Domain/Note';
import { Pitch } from '../../Domain/Pitch';
Severity: Minor
Found in src/__test__/Domain/Barry.test.ts - About 2 hrs to fix

    Function executeCommand has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      executeCommand(command: BarryHarrisCommand) {
        switch (command.command) {
          case 'ArpeggioUpFrom':
            this.line.arpeggioUpFrom(command.degree);
            break;
    Severity: Minor
    Found in src/UseCases/Barry.ts - About 1 hr to fix

      Function scaleDownExtraHalfSteps has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        scaleDownExtraHalfSteps(to: ScaleDegree, from: ScaleDegree) {
          let rawLine = this.scale.down(from, to);
      
          if (this.lineStartsAtChordTone(from)) {
            rawLine = rawLine.insertHalfToneBetween(
      Severity: Minor
      Found in src/Domain/Barry.ts - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language