pedromsantos/glenn

File Guitar.test.ts has 373 lines of code (exceeds 250 allowed). Consider refactoring.

Wontfix

import * as fc from 'fast-check';

import {
  BlankFret,
  Fret,

Similar blocks of code found in 3 locations. Consider refactoring.

Wontfix

    test('Open B', () => {
      const { sixth, fifth, fourth, third, second, first } = GuitarTunningStrings(
        GuitarTuning.OpenB
      );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Wontfix

    test('Eb', () => {
      const { sixth, fifth, fourth, third, second, first } = GuitarTunningStrings(
        GuitarTuning.EFlat
      );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Wontfix

    test('Open A', () => {
      const { sixth, fifth, fourth, third, second, first } = GuitarTunningStrings(
        GuitarTuning.OpenA
      );

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position fourth string', () => {
      const frets = GuitarString.Fourth.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Fourth, 1, Pitch.DSharp, Octave.C3),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on D position', () => {
      const frets = GuitarString.Sixth.fretsFor(Position.D);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Sixth, 11, Pitch.DSharp, Octave.C3),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position third string', () => {
      const frets = GuitarString.Third.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Third, 1, Pitch.GSharp, Octave.C3),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position second string', () => {
      const frets = GuitarString.Second.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Second, 1, Pitch.C, Octave.C4),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position first string', () => {
      const frets = GuitarString.First.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.First, 1, Pitch.F, Octave.C4),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position fifth string', () => {
      const frets = GuitarString.Fifth.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Fifth, 1, Pitch.ASharp, Octave.C2),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on G position', () => {
      const frets = GuitarString.Sixth.fretsFor(Position.G);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Sixth, 6, Pitch.ASharp, Octave.C2),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on C position sixth string', () => {
      const frets = GuitarString.Sixth.fretsFor(Position.C);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Sixth, 1, Pitch.F, Octave.C2),

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Wontfix

    test('map frets on A position', () => {
      const frets = GuitarString.Sixth.fretsFor(Position.A);

      expect([...frets]).toStrictEqual([
        new Fret(GuitarString.Sixth, 4, Pitch.GSharp, Octave.C2),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('fret is outside normal range', () => {
      const lowFret = new Fret(GuitarString.First, 5);
      const highFret = new Fret(GuitarString.First, 7);

      const fretTooLow = new Fret(GuitarString.First, 4);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test('fret is exactly at boundaries', () => {
      const lowFret = new Fret(GuitarString.First, 5);
      const highFret = new Fret(GuitarString.First, 7);

      const fretAtLow = new Fret(GuitarString.First, 5);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

  test('Not be equal if not on same string', () => {
    const fret1 = new Fret(GuitarString.First, 1);
    const fret2 = new Fret(GuitarString.Second, 1);

    expect(fret1.equals(fret2)).toBeFalsy();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

  test('Not be equal if not on same fret', () => {
    const fret1 = new Fret(GuitarString.First, 1);
    const fret2 = new Fret(GuitarString.First, 2);

    expect(fret1.equals(fret2)).toBeFalsy();

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

    test('map G to third fret', () => {
      expect(GuitarString.Sixth.fretFor(Pitch.G)).toStrictEqual(
        new Fret(GuitarString.Sixth, 3, Pitch.G)
      );
    });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

    test('map E to open string', () => {
      expect(GuitarString.Sixth.fretFor(Pitch.E)).toStrictEqual(
        new Fret(GuitarString.Sixth, 0, Pitch.E)
      );
    });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

    test('map F# to second fret', () => {
      expect(GuitarString.Sixth.fretFor(Pitch.FSharp)).toStrictEqual(
        new Fret(GuitarString.Sixth, 2, Pitch.FSharp)
      );
    });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

    test('map Gb to second fret', () => {
      expect(GuitarString.Sixth.fretFor(Pitch.GFlat)).toStrictEqual(
        new Fret(GuitarString.Sixth, 2, Pitch.GFlat)
      );
    });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Wontfix

    test('map F to first fret', () => {
      expect(GuitarString.Sixth.fretFor(Pitch.F)).toStrictEqual(
        new Fret(GuitarString.Sixth, 1, Pitch.F)
      );
    });

• Read up
  Read up