Sign upLogin

pedrozath/coltrane

View on GitHub
Star

Showing 29 of 29 total issues

Class Chord has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Chord
        include Comparable
        attr_reader :guitar_notes, :guitar, :free_fingers, :target_chord, :barre

        MAX_FRET_SPAN = 3
Severity: Minor
Found in lib/coltrane/representation/guitar/chord.rb - About 4 hrs to fix

    Class Interval has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Interval < IntervalClass
      attr_reader :letter_distance, :cents
      alias compound? compound

      class << self
    Severity: Minor
    Found in lib/coltrane/theory/interval.rb - About 3 hrs to fix

      Class IntervalClass has 28 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class IntervalClass < FrequencyInterval
      QUALITY_SEQUENCE = [
        %w[P],
        %w[m M],
        %w[m M],
      Severity: Minor
      Found in lib/coltrane/theory/interval_class.rb - About 3 hrs to fix

        Method border has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

                def border(x, y)
          edge = [guitar.tuning.size * 2 - 2, chord_height + 1]
          x_on_start  = x == 0
          y_on_start  = y == 0
          x_on_edge   = x == edge[0]
        Severity: Minor
        Found in lib/coltrane/renderers/text_renderer/representation_guitar_chord_drawer.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render_notes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

                def render_notes
          guitar_notes.strings.reverse.map.with_index.map do |string, str_i|
            Array.new(frets + 2) do |i|
              if i.zero?
                Paint[
        Severity: Minor
        Found in lib/coltrane/renderers/text_renderer/representation_guitar_note_set_drawer.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class PitchClass has 22 methods (exceeds 20 allowed). Consider refactoring.
        Open

            class PitchClass
      attr_reader :integer
      include Comparable

      NOTATION = %w[C C# D D# E F F# G G# A A# B].freeze
        Severity: Minor
        Found in lib/coltrane/theory/pitch_class.rb - About 2 hrs to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                'Major Second' => {
        'Perfect Fifth' => {
          'name' => 'Msus2',
          'Major Sixth' => {
            'name' => 'M6sus2',
          Severity: Major
          Found in lib/coltrane/theory/qualities.rb and 2 other locations - About 2 hrs to fix
          lib/coltrane/theory/qualities.rb on lines 62..120
          lib/coltrane/theory/qualities.rb on lines 192..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                'Perfect Fourth' => {
        'Perfect Fifth' => {
          'name' => 'Msus4',
          'Major Sixth' => {
            'name' => 'M6sus4',
          Severity: Major
          Found in lib/coltrane/theory/qualities.rb and 2 other locations - About 2 hrs to fix
          lib/coltrane/theory/qualities.rb on lines 62..120
          lib/coltrane/theory/qualities.rb on lines 127..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                'Major Third' => {
        'Perfect Fifth' => {
          'name' => 'M',
          'Major Sixth' => {
            'name' => 'M6',
          Severity: Major
          Found in lib/coltrane/theory/qualities.rb and 2 other locations - About 2 hrs to fix
          lib/coltrane/theory/qualities.rb on lines 127..185
          lib/coltrane/theory/qualities.rb on lines 192..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File qualities.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          module Qualities
  QUALITIES = {
    'Perfect Unison' => {
      'Minor Third' => {
        'Diminished Fifth' => {
          Severity: Minor
          Found in lib/coltrane/theory/qualities.rb - About 2 hrs to fix

            Class IntervalSequence has 21 methods (exceeds 20 allowed). Consider refactoring.
            Open

                class IntervalSequence
      extend Forwardable
      attr_reader :intervals

      def_delegators :@intervals, :map, :each, :[], :size,
            Severity: Minor
            Found in lib/coltrane/theory/interval_sequence.rb - About 2 hrs to fix

              Class Scale has 21 methods (exceeds 20 allowed). Consider refactoring.
              Open

                  class Scale
      extend ClassicScales
      extend Forwardable

      def_delegators :notes, :accidentals, :sharps, :flats
              Severity: Minor
              Found in lib/coltrane/theory/scale.rb - About 2 hrs to fix

                Method find_by_notation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                        def self.find_by_notation(guitar, chord_notation)
          chord_notation
          .split('-')
          .map
          .with_index do |n, i|
                Severity: Minor
                Found in lib/coltrane/representation/guitar/chord.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def initialize(arg_1 = nil, arg_2 = nil, ascending: true,
                     letter_distance: nil,
                     semitones: nil,
                     compound: false)
        if arg_1 && !arg_2 # assumes arg_1 is a letter
                Severity: Minor
                Found in lib/coltrane/theory/interval.rb - About 1 hr to fix

                  Method fetch_descendant_chords has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def fetch_descendant_chords
          return [self] if guitar_notes.size >= guitar.strings.size
          possible_new_notes(notes_available.positive?).reduce([]) do |memo, n|
            barre = n.fret if guitar_notes.last == n.fret
            fingers_change = n.fret == barre || n.fret.zero? ? 0 : 1
                  Severity: Minor
                  Found in lib/coltrane/representation/guitar/chord.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def initialize(arg_1 = nil, arg_2 = nil, ascending: true,
                     letter_distance: nil,
                     semitones: nil,
                     compound: false)
        if arg_1 && !arg_2 # assumes arg_1 is a letter
                  Severity: Minor
                  Found in lib/coltrane/theory/interval.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def initialize(notation = nil, chord: nil, key: nil, scale: nil)
        if notation.nil? && chord.nil? || key.nil? && scale.nil?
          raise WrongKeywordsError,
                '[notation, [scale: || key:]] '\
                '[chord:, [scale: || key:]] '\
                  Severity: Minor
                  Found in lib/coltrane/theory/roman_chord.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def initialize(notation_arg = nil,
                     note: nil,
                     octave: nil,
                     notation: nil,
                     frequency: nil)
                  Severity: Minor
                  Found in lib/coltrane/theory/pitch.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method chords has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def chords(size = 3..12)
        size = (size..size) if size.is_a?(Integer)
        scale_rotations = interval_sequence.inversions
        ChordQuality.intervals_per_name.reduce([]) do |memo1, (qname, qintervals)|
          next memo1 unless size.include?(qintervals.size)
                  Severity: Minor
                  Found in lib/coltrane/theory/scale.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def initialize(*intervals, notes: nil, relative_intervals: nil)
        if intervals.any?
          @intervals = if intervals.first.is_a?(Interval)
                         intervals
                       else
                  Severity: Minor
                  Found in lib/coltrane/theory/interval_sequence.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language