Sign upLogin

penemue/keap

View on GitHub
Star
src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt

Summary

Maintainability
A
0 mins
Test Coverage

Class PriorityQueue has 30 methods (exceeds 20 allowed). Consider refactoring.
Invalid

/**
 * A priority [queue][java.util.Queue] based on keap, a heap data structure similar to binary heap.
 * It maintains separately the [queue][queue] of elements and the [tournament tree][heap] atop the queue.
 * The elements of the priority queue are ordered according to their [natural ordering][java.lang.Comparable],
 * or by a [comparator][Comparator] provided at queue construction time, depending on which constructor is
Severity: Minor
Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 3 hrs to fix

    File PriorityQueue.kt has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Invalid

    /**
 * Copyright 2016 - 2024 Vyacheslav Lukianov (https://github.com/penemue)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 2 hrs to fix

      Method offer has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
      Invalid

          /**
     * Inserts the specified element into this priority queue.
     *
     * @return `true` (as specified by [Queue.offer()][java.util.Queue#offer])
     * @throws ClassCastException if the specified element cannot be compared with elements currently in this
      Severity: Minor
      Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method offer has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

          /**
     * Inserts the specified element into this priority queue.
     *
     * @return `true` (as specified by [Queue.offer()][java.util.Queue#offer])
     * @throws ClassCastException if the specified element cannot be compared with elements currently in this
      Severity: Minor
      Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 1 hr to fix

        Method iterator has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

            /**
     * Returns an iterator over the elements in this queue. The iterator does not return the elements
     * in any particular order.
     *
     * @return an iterator over the elements in this queue
        Severity: Minor
        Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 1 hr to fix

          Avoid too many return statements within this method.
          Invalid

                  if (value1 == null) return i2
          Severity: Major
          Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 30 mins to fix

            Avoid too many return statements within this method.
            Invalid

                    return if (compareValues(value1, value2) <= 0) i1 else i2
            Severity: Major
            Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Invalid

                          if (min(minLeft, minLeft + 1) == minLeft + 1) {
                swapNeighboursAt(minLeft)
            }
              Severity: Minor
              Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt and 1 other location - About 35 mins to fix
              src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt on lines 289..291

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Invalid

                          if (min(minRight, minRight + 1) == minRight + 1) {
                swapNeighboursAt(minRight)
            }
              Severity: Minor
              Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt and 1 other location - About 35 mins to fix
              src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt on lines 285..287

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Invalid

                              q.forEach { it?.apply { queue[j++] = this } }
              Severity: Minor
              Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt and 1 other location - About 30 mins to fix
              src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt on lines 185..185

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Invalid

                              q.forEach { it?.apply { q[j++] = this } }
              Severity: Minor
              Found in src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt and 1 other location - About 30 mins to fix
              src/main/kotlin/com/github/penemue/keap/PriorityQueue.kt on lines 183..183

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status