perobertson/heroku-platform-helper

View on GitHub

Showing 41 of 41 total issues

Class has too many lines. [124/100]
Open

  class App
    attr_reader :app_name

    def initialize(api_key, app_name)
      @api_key = api_key
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for scale is too high. [51.26/15]
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [45/10]
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [33/10]
Open

    def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
      remote = @app_name
      heroku = PlatformAPI.connect_oauth @api_key

      git_url = heroku.app.info(@app_name)['git_url']
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for deploy is too high. [31.38/15]
Open

    def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
      remote = @app_name
      heroku = PlatformAPI.connect_oauth @api_key

      git_url = heroku.app.info(@app_name)['git_url']
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [17/10]
Open

    def logger
      @logger ||= Logger.new(STDOUT).tap do |log|
        log.progname = self.name
        case ENV['LOG_LEVEL']
        when 'unknown'
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for scale is too high. [13/7]
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [14/10]
Open

    def migrate
      heroku = PlatformAPI.connect_oauth @api_key
      payload = {
        attach: true,
        command: 'rake db:migrate'
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method scale has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for scale is too high. [9/6]
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method scale has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def scale(worker: nil, clock: nil)
      heroku = PlatformAPI.connect_oauth @api_key

      payload = {
        updates: []
Severity: Minor
Found in lib/heroku_helper/app.rb - About 1 hr to fix

    Cyclomatic complexity for deploy is too high. [7/6]
    Open

        def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
          remote = @app_name
          heroku = PlatformAPI.connect_oauth @api_key
    
          git_url = heroku.app.info(@app_name)['git_url']
    Severity: Minor
    Found in lib/heroku_helper/app.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Perceived complexity for deploy is too high. [8/7]
    Open

        def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
          remote = @app_name
          heroku = PlatformAPI.connect_oauth @api_key
    
          git_url = heroku.app.info(@app_name)['git_url']
    Severity: Minor
    Found in lib/heroku_helper/app.rb by rubocop

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
      if cond                       # 1
        case var                    # 2 (0.8 + 4 * 0.2, rounded)
        when 1 then func_one
        when 2 then func_two
        when 3 then func_three
        when 4..10 then func_other
        end
      else                          # 1
        do_something until a && b   # 2
      end                           # ===
    end                             # 7 complexity points

    Method deploy has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
          remote = @app_name
          heroku = PlatformAPI.connect_oauth @api_key
    
          git_url = heroku.app.info(@app_name)['git_url']
    Severity: Minor
    Found in lib/heroku_helper/app.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deploy has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def deploy(branch:, worker: nil, clock: nil, enable_maintenance: false)
          remote = @app_name
          heroku = PlatformAPI.connect_oauth @api_key
    
          git_url = heroku.app.info(@app_name)['git_url']
    Severity: Minor
    Found in lib/heroku_helper/app.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if formation['quantity'] != worker
                  payload[:updates] << {
                    process: 'worker',
                    quantity: worker,
                    size: size
      Severity: Minor
      Found in lib/heroku_helper/app.rb and 1 other location - About 25 mins to fix
      lib/heroku_helper/app.rb on lines 136..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if formation['quantity'] != clock
                  payload[:updates] << {
                    process: 'clock',
                    quantity: clock,
                    size: size
      Severity: Minor
      Found in lib/heroku_helper/app.rb and 1 other location - About 25 mins to fix
      lib/heroku_helper/app.rb on lines 125..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Add an empty line after magic comments.
      Open

      lib = File.expand_path('../lib', __FILE__)
      Severity: Minor
      Found in heroku-platform-helper.gemspec by rubocop

      Checks for a newline after the final magic comment.

      Example:

      # good
      # frozen_string_literal: true
      
      # Some documentation for Person
      class Person
        # Some code
      end
      
      # bad
      # frozen_string_literal: true
      # Some documentation for Person
      class Person
        # Some code
      end

      Missing top-level class documentation comment.
      Open

        class App
      Severity: Minor
      Found in lib/heroku_helper/app.rb by rubocop

      This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

      The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

      Example:

      # bad
      class Person
        # ...
      end
      
      # good
      # Description/Explanation of Person class
      class Person
        # ...
      end

      Redundant self detected.
      Open

              log.progname = self.name
      Severity: Minor
      Found in lib/heroku_helper/app.rb by rubocop

      This cop checks for redundant uses of self.

      The usage of self is only needed when:

      • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

      • Calling an attribute writer to prevent an local variable assignment.

      Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

      Note we allow uses of self with operators because it would be awkward otherwise.

      Example:

      # bad
      def foo(bar)
        self.baz
      end
      
      # good
      def foo(bar)
        self.bar  # Resolves name clash with the argument.
      end
      
      def foo
        bar = 1
        self.bar  # Resolves name clash with the local variable.
      end
      
      def foo
        %w[x y z].select do |bar|
          self.bar == bar  # Resolves name clash with argument of the block.
        end
      end
      Severity
      Category
      Status
      Source
      Language