Sign upLogin

peryaudo/bcwallet

View on GitHub
Star

Showing 25 of 25 total issues

Avoid too many return statements within this method.
Open

      return
Severity: Major
Found in bcwallet.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        when 'block'    then return if require_args(1)
    Severity: Major
    Found in bcwallet.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          when 'balance'  then return if require_args(0)
      Severity: Major
      Found in bcwallet.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            when 'send'     then return if require_args(3)
        Severity: Major
        Found in bcwallet.rb - About 30 mins to fix

          Method read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def read(socket)
    packet = read_packet(socket)

    expected_magic    = [IS_TESTNET ? '0b110907' : 'f9beb4d9'].pack('H*')
    expected_checksum = Key.hash256(packet[:payload])[0, 4]
          Severity: Minor
          Found in bcwallet.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language