petenelson/wp-rest-api-toolbox

View on GitHub
includes/settings/class-rest-api-toolbox-settings-base.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method settings_input has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        static public function settings_input( $args ) {

            $args = wp_parse_args( $args,
                array(
                    'name' => '',
Severity: Minor
Found in includes/settings/class-rest-api-toolbox-settings-base.php - About 1 hr to fix

    Method settings_yes_no has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            static public function settings_yes_no( $args ) {
    
                $args = wp_parse_args( $args,
                    array(
                        'name' => '',
    Severity: Minor
    Found in includes/settings/class-rest-api-toolbox-settings-base.php - About 1 hr to fix

      Function change_setting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              static public function change_setting( $key, $setting, $value, $sanitize_callback = null ) {
                  if ( ! self::settings_key_is_valid( $key ) ) {
                      return false;
                  }
      
      
      Severity: Minor
      Found in includes/settings/class-rest-api-toolbox-settings-base.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused local variables such as '$min_max_step'.
      Open

                  $min_max_step = '';

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      There are no issues that match your filters.

      Category
      Status