Sign upLogin

peter50216/pwntools-ruby

View on GitHub
Star
lib/pwnlib/shellcraft/generators/amd64/common/pushstr.rb

Summary

Maintainability
A
45 mins
Test Coverage
A
100%

Method pushstr has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
Open

          def pushstr(str, append_null: true)
            # This will not affect callee's +str+.
            str += "\x00" if append_null && !str.end_with?("\x00")
            return if str.empty?
Severity: Minor
Found in lib/pwnlib/shellcraft/generators/amd64/common/pushstr.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status