Sign upLogin

petities/petitions.eu

View on GitHub
Star
app/controllers/signatures_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage
C
78%

Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    # try to find old signature first
    email = signature_params[:person_email]
    @signature = Signature.find_by(person_email: email, petition: @petition)
Severity: Minor
Found in app/controllers/signatures_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method confirm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def confirm
    @petition = @signature.petition
    # generate the update signature url
    @url = petition_signature_confirm_submit_path(@petition, @signature.unique_key)
Severity: Minor
Found in app/controllers/signatures_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

  # TODO add proper validation
Severity: Minor
Found in app/controllers/signatures_controller.rb by fixme

There are no issues that match your filters.

Category
Status