Sign upLogin

petspats/pyha

View on GitHub
Star
pyha/simulation/plotter.py

Summary

Maintainability
A
1 hr
Test Coverage

Function plot_frequency_domain has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def plot_frequency_domain(simulations, name='Frequency domain', window=plt.mlab.window_hanning, xlim=None, ylim=None):
Severity: Minor
Found in pyha/simulation/plotter.py - About 35 mins to fix

    Function plot_time_domain has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def plot_time_domain(simulations, name='Time domain'):
    simulations["MODEL"] = np.array(simulations["MODEL"])
    simulations["HARDWARE"] = np.array(simulations["HARDWARE"])
    if is_float(simulations["MODEL"][0]):
        fig, ax = plt.subplots(2, sharex="all", figsize=figsize, gridspec_kw={'height_ratios': [4, 2]})
    Severity: Minor
    Found in pyha/simulation/plotter.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status