Sign upLogin

pfitzer/dnsbl

View on GitHub
Star

Showing 4 of 4 total issues

Missing class import via use statement (line '127', column '23').
Open

            throw new \InvalidArgumentException($e->getMessage());
Severity: Minor
Found in src/dnsbl.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '203', column '23').
Open

            throw new \InvalidArgumentException('It`s not allowed to use http or https in blacklist name!');
Severity: Minor
Found in src/dnsbl.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '192', column '23').
Open

            throw new \InvalidArgumentException(sprintf('"%s" is not a valid ip address!', $lookupIp));
Severity: Minor
Found in src/dnsbl.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function lookup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function lookup($lookupIp, $type='A'): array
    {
        $result = array();
        foreach ($this->blackLists as $bl) {
            try {
Severity: Minor
Found in src/dnsbl.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language