Sign upLogin

pgoultiaev/aoc2017

View on GitHub
Star
7/7.go

Summary

Maintainability
A
1 hr
Test Coverage

Function findUnbalancedNodes has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func findUnbalancedNodes(n Node, diff int) {
    if len(n.children) > 2 {
        childWeights := make(map[int]int)

        for i := range n.children {
Severity: Minor
Found in 7/7.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

exported type Node should have comment or be unexported
Open

type Node struct {
Severity: Minor
Found in 7/7.go by golint

There are no issues that match your filters.

Category
Status