Sign upLogin

phan/phan

View on GitHub
Star

Showing 4,886 of 4,939 total issues

Method generateIssueMap has 4385 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function generateIssueMap(): array
    {
        // phpcs:disable Generic.Files.LineLength
        /**
         * @var list<Issue>
Severity: Major
Found in src/Phan/Issue.php - About 3 wks to fix

    File ConstantDocumentationMap.php has 3697 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php // phpcs:ignoreFile
namespace Phan\Language\Internal;

/**
 * This contains descriptions used by Phan for hover text of internal constants (global and class constants) in the language server mode.
    Severity: Major
    Found in src/Phan/Language/Internal/ConstantDocumentationMap.php - About 1 wk to fix

      Function __construct has a Cognitive Complexity of 210 (exceeds 5 allowed). Consider refactoring.
      Open

          private function __construct(array $opts, array $argv)
    {
        self::detectAndConfigureColorSupport($opts);

        if (\array_key_exists('extended-help', $opts)) {
      Severity: Minor
      Found in src/Phan/CLI.php - About 4 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getAnalyzeFunctionCallClosuresStatic has 714 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        $stop_exception = new StopParamAnalysisException();

        /**
      Severity: Major
      Found in src/Phan/Plugin/Internal/MiscParamPlugin.php - About 3 days to fix

        File ConditionVisitorUtil.php has 1275 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

declare(strict_types=1);

namespace Phan\Analysis;
        Severity: Major
        Found in src/Phan/Analysis/ConditionVisitorUtil.php - About 3 days to fix

          File ClassDocumentationMap.php has 1235 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php // phpcs:ignoreFile
namespace Phan\Language\Internal;

/**
 * This contains descriptions used by Phan for hover text of internal classes and interfaces
          Severity: Major
          Found in src/Phan/Language/Internal/ClassDocumentationMap.php - About 3 days to fix

            Function getReturnTypeOverridesStatic has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);
            Severity: Minor
            Found in src/Phan/Plugin/Internal/ArrayReturnTypeOverridePlugin.php - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File FunctionSignatureMapReal_php73.php has 1183 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

declare(strict_types=1);

/**
            Severity: Major
            Found in src/Phan/Language/Internal/FunctionSignatureMapReal_php73.php - About 3 days to fix

              Method __construct has 589 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function __construct(array $opts, array $argv)
    {
        self::detectAndConfigureColorSupport($opts);

        if (\array_key_exists('extended-help', $opts)) {
              Severity: Major
              Found in src/Phan/CLI.php - About 2 days to fix

                File FunctionSignatureMapReal.php has 1139 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

declare(strict_types=1);

/**
                Severity: Major
                Found in src/Phan/Language/Internal/FunctionSignatureMapReal.php - About 2 days to fix

                  File MiscParamPlugin.php has 1061 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
                  Severity: Major
                  Found in src/Phan/Plugin/Internal/MiscParamPlugin.php - About 2 days to fix

                    Method getReturnTypeOverridesStatic has 531 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);
                    Severity: Major
                    Found in src/Phan/Plugin/Internal/ArrayReturnTypeOverridePlugin.php - About 2 days to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function asExpandedTypes(
        CodeBase $code_base,
        int $recursion_depth = 0
    ): UnionType {
        // We're going to assume that if the type hierarchy
                      Severity: Major
                      Found in src/Phan/Language/Type/GenericIterableType.php and 1 other location - About 2 days to fix
                      src/Phan/Language/Type/GenericIterableType.php on lines 388..465

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 513.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function asExpandedTypesPreservingTemplate(
        CodeBase $code_base,
        int $recursion_depth = 0
    ): UnionType {
        // We're going to assume that if the type hierarchy
                      Severity: Major
                      Found in src/Phan/Language/Type/GenericIterableType.php and 1 other location - About 2 days to fix
                      src/Phan/Language/Type/GenericIterableType.php on lines 295..372

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 513.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function getAnalyzeFunctionCallClosuresStatic has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private static function getAnalyzeFunctionCallClosuresStatic(): array
    {
        $stop_exception = new StopParamAnalysisException();

        /**
                      Severity: Minor
                      Found in src/Phan/Plugin/Internal/MiscParamPlugin.php - About 2 days to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File FunctionSignatureMap_php80_delta.php has 883 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php // phpcs:ignoreFile

/**
 * This contains the information needed to convert the function signatures for php 8.0 to php 7.4 (and vice versa)
 *
                      Severity: Major
                      Found in src/Phan/Language/Internal/FunctionSignatureMap_php80_delta.php - About 2 days to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if ($switch_kind === ast\AST_VAR) {
                $switch_variable = (new ConditionVisitor($this->code_base, $this->context))->getVariableFromScope($switch_case_node, $this->context);
                if (!$switch_variable) {
                    return self::NOOP_SWITCH_COND_ANALYZER;
                }
                        Severity: Major
                        Found in src/Phan/BlockAnalysisVisitor.php and 1 other location - About 2 days to fix
                        src/Phan/BlockAnalysisVisitor.php on lines 2292..2346

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 433.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if ($match_kind === ast\AST_VAR) {
                $match_variable = (new ConditionVisitor($this->code_base, $this->context))->getVariableFromScope($match_case_node, $this->context);
                if (!$match_variable) {
                    return self::NOOP_SWITCH_COND_ANALYZER;
                }
                        Severity: Major
                        Found in src/Phan/BlockAnalysisVisitor.php and 1 other location - About 2 days to fix
                        src/Phan/BlockAnalysisVisitor.php on lines 1698..1752

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 433.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        File IncompatibleXMLSignatureDetector.php has 878 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php

declare(strict_types=1);

use Phan\Config;
                        Severity: Major
                        Found in internal/lib/IncompatibleXMLSignatureDetector.php - About 2 days to fix

                          File UseReturnValuePlugin.php has 823 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;
                          Severity: Major
                          Found in src/Phan/Plugin/Internal/UseReturnValuePlugin.php - About 1 day to fix
                            Severity
                            Category
                            Status
                            Source
                            Language