Showing 3,225 of 4,939 total issues

Method getProperty has 213 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getProperty(
        bool $is_static,
        bool $is_known_assignment = false
    ): Property {
        $node = $this->node;
Severity: Major
Found in src/Phan/AST/ContextNode.php - About 1 day to fix

    Method analyzePrintfPattern has 211 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function analyzePrintfPattern(CodeBase $code_base, Context $context, FunctionInterface $function, $pattern_node, $arg_nodes): void
        {
            // Given a node, extract the printf directive and whether or not it could be translated
            $primitive_for_fmtstr = $this->astNodeToPrimitive($code_base, $context, $pattern_node);
            /**
    Severity: Major
    Found in .phan/plugins/PrintfCheckerPlugin.php - About 1 day to fix

      Function visitVar has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitVar(Node $node): UnionType
          {
              // $$var or ${...} (whose idea was that anyway?)
              $name_node = $node->children['name'];
              if (($name_node instanceof Node)) {
      Severity: Minor
      Found in src/Phan/AST/UnionTypeVisitor.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function checkPossiblyInfiniteLoopNodes has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkPossiblyInfiniteLoopNodes(
              VariableGraph $variable_graph,
              VariableTrackerVisitor $variable_tracker_visitor
          ): void {
              $loop_nodes = $variable_tracker_visitor->getPossiblyInfiniteLoopNodes();
      Severity: Minor
      Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function analyzeElementReferenceCounts has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function analyzeElementReferenceCounts(
              CodeBase $code_base,
              AddressableElement $element,
              string $issue_type
          ): void {
      Severity: Minor
      Found in src/Phan/Analysis/ReferenceCountsAnalyzer.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File InferPureVisitor.php has 510 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      declare(strict_types=1);
      
      namespace Phan\AST;
      Severity: Major
      Found in src/Phan/AST/InferPureVisitor.php - About 1 day to fix

        ArrayShapeType has 57 functions (exceeds 20 allowed). Consider refactoring.
        Open

        final class ArrayShapeType extends ArrayType implements GenericArrayInterface
        {
            /** @phan-override */
            public const NAME = 'array';
        
        
        Severity: Major
        Found in src/Phan/Language/Type/ArrayShapeType.php - About 1 day to fix

          File IncompatibleRealStubsSignatureDetector.php has 501 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          declare(strict_types=1);
          
          use Phan\Analysis;
          Severity: Major
          Found in internal/lib/IncompatibleRealStubsSignatureDetector.php - About 1 day to fix

            BlockAnalysisVisitor has 56 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class BlockAnalysisVisitor extends AnalysisVisitor
            {
            
                /**
                 * @var Node[]
            Severity: Major
            Found in src/Phan/BlockAnalysisVisitor.php - About 1 day to fix

              Method getConfigErrors has 200 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function getConfigErrors(array $configuration): array
                  {
                      /**
                       * @param mixed $value
                       */
              Severity: Major
              Found in src/Phan/Config.php - About 1 day to fix

                VariableTrackerVisitor has 56 functions (exceeds 20 allowed). Consider refactoring.
                Open

                final class VariableTrackerVisitor extends AnalysisVisitor
                {
                    /**
                     * This shared graph instance maps definitions of variables (in a function-like context)
                     * to the uses of that variable.
                Severity: Major
                Found in src/Phan/Plugin/Internal/VariableTracker/VariableTrackerVisitor.php - About 1 day to fix

                  Function resolveArrayShapeElementTypesForOffset has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function resolveArrayShapeElementTypesForOffset(UnionType $union_type, $dim_value, bool $is_computing_real_type_set = false)
                      {
                          /**
                           * @var bool $has_non_array_shape_type this will be true if there are types that support array access
                           *           but have unknown array shapes in $union_type
                  Severity: Minor
                  Found in src/Phan/AST/UnionTypeVisitor.php - About 7 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File VariableTrackerPlugin.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  declare(strict_types=1);
                  
                  namespace Phan\Plugin\Internal;
                  Severity: Minor
                  Found in src/Phan/Plugin/Internal/VariableTrackerPlugin.php - About 7 hrs to fix

                    Method analyzeOverrideSignatureForOverriddenMethod has 191 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private static function analyzeOverrideSignatureForOverriddenMethod(
                            CodeBase $code_base,
                            Method $method,
                            Clazz $class,
                            Method $o_method
                    Severity: Major
                    Found in src/Phan/Analysis/ParameterTypesAnalyzer.php - About 7 hrs to fix

                      File Request.php has 483 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      declare(strict_types=1);
                      
                      namespace Phan\Daemon;
                      Severity: Minor
                      Found in src/Phan/Daemon/Request.php - About 7 hrs to fix

                        Function analyzeOverrideRealSignature has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private static function analyzeOverrideRealSignature(
                                CodeBase $code_base,
                                Method $method,
                                Clazz $class,
                                Method $o_method,
                        Severity: Minor
                        Found in src/Phan/Analysis/ParameterTypesAnalyzer.php - About 7 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function extractDocComment has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function extractDocComment(string $doc_comment, int $comment_category = null, UnionType $element_type = null, bool $remove_type = false): string
                            {
                                // Trim the start and the end of the doc comment.
                                //
                                // We leave in the second `*` of `/**` so that every single non-empty line
                        Severity: Minor
                        Found in src/Phan/Language/Element/MarkupDescription.php - About 7 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function castTypeListToCountable has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function castTypeListToCountable(CodeBase $code_base, array $type_list, bool $assume_subclass_implements_countable): array
                            {
                                $result = [];
                                foreach ($type_list as $type) {
                                    if ($type instanceof IterableType) {
                        Severity: Minor
                        Found in src/Phan/Language/UnionType.php - About 7 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File ASTReverter.php has 465 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        declare(strict_types=1);
                        
                        namespace Phan\AST;
                        Severity: Minor
                        Found in src/Phan/AST/ASTReverter.php - About 7 hrs to fix

                          IncompatibleSignatureDetectorBase has 50 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          abstract class IncompatibleSignatureDetectorBase
                          {
                              use Memoize;
                          
                              const FUNCTIONLIKE_BLACKLIST = '@' .
                          Severity: Minor
                          Found in internal/lib/IncompatibleSignatureDetectorBase.php - About 7 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language