Sign upLogin

phanan/koel

View on GitHub
Star

Showing 336 of 336 total issues

Function test has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected test () {
    it('initializes the store', async () => {
      const songSyncMock = this.mock(songStore, 'syncWithVault')
      const albumSyncMock = this.mock(albumStore, 'syncWithVault')
      const artistSyncMock = this.mock(artistStore, 'syncWithVault')
Severity: Minor
Found in resources/assets/js/stores/overviewStore.spec.ts - About 1 hr to fix

    Function init has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const init = (container: HTMLElement) => {
  const sceneInit = new SceneInit(container)

  const analyser = audioService.analyzer
  analyser.fftSize = 512
    Severity: Minor
    Found in resources/assets/js/visualizers/waveform/index.ts - About 1 hr to fix

      Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor (container: HTMLElement, fov = 36) {
    this.container = container
    this.fov = fov

    this.camera = new THREE.PerspectiveCamera(
      Severity: Minor
      Found in resources/assets/js/visualizers/waveform/lib/SceneInit.ts - About 1 hr to fix

        Function listenToMediaEvents has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private listenToMediaEvents (media: HTMLMediaElement) {
    media.addEventListener('error', () => this.playNext(), true)

    media.addEventListener('ended', () => {
      if (commonStore.state.use_last_fm && userStore.current.preferences!.lastfm_session_key) {
        Severity: Minor
        Found in resources/assets/js/services/playbackService.ts - About 1 hr to fix

          Function startDragging has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const startDragging = (event: DragEvent, dragged: Draggable) => {
    if (!event.dataTransfer) {
      return
    }
          Severity: Minor
          Found in resources/assets/js/composables/useDragAndDrop.ts - About 1 hr to fix

            Method setUpDatabase has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function setUpDatabase(): void
    {
        $config = [
            'DB_HOST' => '',
            'DB_PORT' => '',
            Severity: Minor
            Found in app/Console/Commands/InitCommand.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.render(AlbumScreen, {
      global: {
        stubs: {
          SongList: this.stub('song-list'),
          AlbumCard: this.stub('album-card'),
              Severity: Major
              Found in resources/assets/js/components/screens/AlbumScreen.spec.ts and 1 other location - About 1 hr to fix
              resources/assets/js/components/screens/ArtistScreen.spec.ts on lines 31..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.render(ArtistScreen, {
      global: {
        stubs: {
          ArtistInfo: this.stub('artist-info'),
          SongList: this.stub('song-list'),
              Severity: Major
              Found in resources/assets/js/components/screens/ArtistScreen.spec.ts and 1 other location - About 1 hr to fix
              resources/assets/js/components/screens/AlbumScreen.spec.ts on lines 33..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function test has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                protected test () {
    it('fetches the recently played songs', async () => {
      const songs = factory<Song>('song', 3)
      const getMock = this.mock(http, 'get').mockResolvedValue(songs)
      const syncMock = this.mock(songStore, 'syncWithVault', songs)
              Severity: Minor
              Found in resources/assets/js/stores/recentlyPlayedStore.spec.ts - About 1 hr to fix

                Function maybeSetUpDatabase has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function maybeSetUpDatabase(): void
    {
        $attempt = 0;

        while (true) {
                Severity: Minor
                Found in app/Console/Commands/InitCommand.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method fromRule has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function fromRule(Rule $rule): self
    {
        $operator = $rule->operator;
        $value = $rule->value;
                Severity: Minor
                Found in app/Values/SmartPlaylistSqlElements.php - About 1 hr to fix

                  Function test has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    protected test () {
    it('creates playlist with no songs', async () => {
      const folder = factory<PlaylistFolder>('playlist-folder')
      const storeMock = this.mock(playlistStore, 'store').mockResolvedValue(factory<Playlist>('playlist'))
                  Severity: Minor
                  Found in resources/assets/js/components/playlist/CreatePlaylistForm.spec.ts - About 1 hr to fix

                    Method fromGetId3Info has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function fromGetId3Info(array $info, string $path): self
    {
        // We prefer ID3v2 tags over ID3v1 tags.
        $tags = array_merge(
            Arr::get($info, 'tags.id3v1', []),
                    Severity: Minor
                    Found in app/Values/SongScanInformation.php - About 1 hr to fix

                      Function setup has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        const setup = () => {
    const referenceElement = extractRef(reference)
    const floatingElement = extractRef(floating)

    floatingElement.style.display = 'none'
                      Severity: Minor
                      Found in resources/assets/js/composables/useFloatingUi.ts - About 1 hr to fix

                        Function test has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          protected test () {
    it.each([[0], [1]])('shuffles all if %s songs are selected', async (selectedCount: number) => {
      const { emitted } = this.renderComponent(selectedCount)

      await this.user.click(screen.getByTitle('Shuffle all songs'))
                        Severity: Minor
                        Found in resources/assets/js/components/song/SongListControls.spec.ts - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                cy.get('[data-testid=user-card].me').within(() => {
        cy.findByTitle('This is you!').should('be.visible')
        cy.findByTitle('User has admin privileges').should('be.visible')
      })
                          Severity: Major
                          Found in cypress/integration/users.spec.ts and 1 other location - About 1 hr to fix
                          cypress/integration/users.spec.ts on lines 68..71

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              cy.get('#usersWrapper [data-testid=user-card]:nth-child(2)').within(() => {
      cy.findByText('Adriana').should('be.visible')
      cy.findByText('adriana@koel.test').should('be.visible')
    })
                          Severity: Major
                          Found in cypress/integration/users.spec.ts and 1 other location - About 1 hr to fix
                          cypress/integration/users.spec.ts on lines 11..14

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              it('does not have an option to download if downloading is disabled', async () => {
      commonStore.state.allow_download = false
      await this.renderComponent()

      expect(screen.queryByText('Download')).toBeNull()
                          Severity: Major
                          Found in resources/assets/js/components/artist/ArtistContextMenu.spec.ts and 1 other location - About 1 hr to fix
                          resources/assets/js/components/album/AlbumContextMenu.spec.ts on lines 63..68

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              it('does not have an option to download if downloading is disabled', async () => {
      commonStore.state.allow_download = false
      await this.renderComponent()

      expect(screen.queryByText('Download')).toBeNull()
                          Severity: Major
                          Found in resources/assets/js/components/album/AlbumContextMenu.spec.ts and 1 other location - About 1 hr to fix
                          resources/assets/js/components/artist/ArtistContextMenu.spec.ts on lines 63..68

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function init has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          const init = (el: ElementWithTooltip, binding: DirectiveBinding) => {
  const $tooltip = getOrCreateTooltip(el)

  // make sure the actual title is removed from the element, but keep a backup for the updated() hook calls
  $tooltip.querySelector<HTMLDivElement>('.tooltip-content')!.innerText = binding.value
                          Severity: Minor
                          Found in resources/assets/js/directives/tooltip.ts - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language