Sign upLogin

phanan/koel

View on GitHub
Star
resources/assets/js/services/playbackService.ts

Summary

Maintainability
D
2 days
Test Coverage

File playbackService.ts has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import isMobile from 'ismobilejs'
import plyr from 'plyr'
import { watch } from 'vue'
import { shuffle, throttle } from 'lodash'
import { commonStore } from '@/stores/commonStore'
Severity: Minor
Found in resources/assets/js/services/playbackService.ts - About 3 hrs to fix

    Function listenToMediaEvents has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      private listenToMediaEvents (media: HTMLMediaElement) {
    media.addEventListener('error', () => this.playNext(), true)

    media.addEventListener('ended', () => {
      if (
    Severity: Minor
    Found in resources/assets/js/services/playbackService.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    PlaybackService has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PlaybackService {
  public player!: Plyr
  private repeatModes: RepeatMode[] = ['NO_REPEAT', 'REPEAT_ALL', 'REPEAT_ONE']
  private initialized = false
    Severity: Minor
    Found in resources/assets/js/services/playbackService.ts - About 2 hrs to fix

      Function listenToMediaEvents has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private listenToMediaEvents (media: HTMLMediaElement) {
    media.addEventListener('error', () => this.playNext(), true)

    media.addEventListener('ended', () => {
      if (
      Severity: Minor
      Found in resources/assets/js/services/playbackService.ts - About 1 hr to fix

        Function showNotification has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public showNotification (playable: Playable) {
    if (!isSong(playable) && !isEpisode(playable)) {
      throw new Error('Invalid playable type.')
    }
        Severity: Minor
        Found in resources/assets/js/services/playbackService.ts - About 1 hr to fix

          Function timeUpdateHandler has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              let timeUpdateHandler = () => {
      const currentPlayable = queueStore.current

      if (!currentPlayable) {
        return
          Severity: Minor
          Found in resources/assets/js/services/playbackService.ts - About 1 hr to fix

            Function play has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              public async play (playable: Playable, position = 0) {
    if (isEpisode(playable)) {
      useEpisodeProgressTracking().trackEpisode(playable)
    }
            Severity: Minor
            Found in resources/assets/js/services/playbackService.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function showNotification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              public showNotification (playable: Playable) {
    if (!isSong(playable) && !isEpisode(playable)) {
      throw new Error('Invalid playable type.')
    }
            Severity: Minor
            Found in resources/assets/js/services/playbackService.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  navigator.mediaSession.setActionHandler('seekbackward', details => {
        this.player.media.currentTime -= (details.seekOffset || 10)
      })
            Severity: Minor
            Found in resources/assets/js/services/playbackService.ts and 1 other location - About 40 mins to fix
            resources/assets/js/services/playbackService.ts on lines 378..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  navigator.mediaSession.setActionHandler('seekforward', details => {
        this.player.media.currentTime += (details.seekOffset || 10)
      })
            Severity: Minor
            Found in resources/assets/js/services/playbackService.ts and 1 other location - About 40 mins to fix
            resources/assets/js/services/playbackService.ts on lines 374..376

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status