Sign upLogin

phapi/middleware-content-negotiation

View on GitHub
Star

Showing 5 of 5 total issues

Function getBestFormat has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBestFormat($accept, $supported)
    {
        // Parse the accept header
        $parts = $this->parseHeader($accept);
Severity: Minor
Found in src/Phapi/Middleware/ContentNegotiation/FormatNegotiation.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseParts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseParts(array $parts = [])
    {
        // Get and unset the mime type
        $mimeType = $parts[0];
        unset($parts[0]);
Severity: Minor
Found in src/Phapi/Middleware/ContentNegotiation/FormatNegotiation.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return $one['index'] < $two['index'] ? -1 : 1;
Severity: Major
Found in src/Phapi/Middleware/ContentNegotiation/FormatNegotiation.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $parts;
    Severity: Major
    Found in src/Phapi/Middleware/ContentNegotiation/FormatNegotiation.php - About 30 mins to fix

      Function __invoke has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next = null)
    {
        // Make sure we have serializers
        if (!isset($this->container['acceptTypes'])) {
            throw new InternalServerError('No serializers seems to be registered');
      Severity: Minor
      Found in src/Phapi/Middleware/ContentNegotiation/FormatNegotiation.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language