phateio/kiris

View on GitHub
app/controllers/application_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class ApplicationController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
  before_action :set_locale!
Severity: Minor
Found in app/controllers/application_controller.rb - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            return 'Hong Kong'
    Severity: Major
    Found in app/controllers/application_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return 'Taipei'
      Severity: Major
      Found in app/controllers/application_controller.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return 'Beijing'
        Severity: Major
        Found in app/controllers/application_controller.rb - About 30 mins to fix

          Method set_locale! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def set_locale!
              I18n.locale = I18n.default_locale
              @@available_locales ||= I18n.available_locales.map(&:to_s)
              if preference_params['locale']
                locale = preference_params['locale']
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status