Sign upLogin

phateio/kiris

View on GitHub
Star
app/controllers/issues_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    set_site_title(I18n.t('issues.new_issue'))
    @typeids ||= ['question', 'suggestion', 'appeal']

    dateline = Time.now.utc
Severity: Minor
Found in app/controllers/issues_controller.rb - About 1 hr to fix

    Method show has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def show
    @item = {}
    @item_replies = []
    id = params[:id]
    issue = Issue.where(id: id).first
    Severity: Minor
    Found in app/controllers/issues_controller.rb - About 1 hr to fix

      Method append has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def append
    id = params[:id]
    issue = Issue.where(id: id).first

    dateline = Time.now.utc
      Severity: Minor
      Found in app/controllers/issues_controller.rb - About 1 hr to fix

        Method update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def update
    id = params[:id]

    issue_id = request.POST[:issue_id].to_i
    issue_status = request.POST[:issue_status].to_s
        Severity: Minor
        Found in app/controllers/issues_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def update
    id = params[:id]

    issue_id = request.POST[:issue_id].to_i
    issue_status = request.POST[:issue_status].to_s
        Severity: Minor
        Found in app/controllers/issues_controller.rb - About 1 hr to fix

          Method destroy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def destroy
    id = params[:id]

    issue_id = request.POST[:issue_id].to_i
    reply_id = request.POST[:reply_id].to_i
          Severity: Minor
          Found in app/controllers/issues_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                @items << {id: issue.id,
                 dateline: issue.dateline,
                 subject: issue.subject,
                 message: issue.message,
                 nickname: nickname,
          Severity: Minor
          Found in app/controllers/issues_controller.rb and 1 other location - About 30 mins to fix
          app/controllers/issues_controller.rb on lines 107..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                @item = {id: issue.id,
               dateline: issue.dateline,
               subject: issue.subject,
               message: issue.message,
               nickname: nickname,
          Severity: Minor
          Found in app/controllers/issues_controller.rb and 1 other location - About 30 mins to fix
          app/controllers/issues_controller.rb on lines 30..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status