Sign upLogin

phattarachai/thaidate

View on GitHub
Star
src/function.php

Summary

Maintainability
A
0 mins
Test Coverage

The method thaidate has a boolean flag argument $buddhistEra, which is a certain sign of a Single Responsibility Principle violation.
Open

function thaidate(string $format = 'j F Y', $timestamp = 'now', bool $buddhistEra = true)
Severity: Minor
Found in src/function.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There must be one blank line after the last USE statement; 2 found;
Open

use Phattarachai\Thaidate\Thaidate;
Severity: Minor
Found in src/function.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in src/function.php by phpcodesniffer

There are no issues that match your filters.

Category
Status