Sign upLogin

philips-software/cogito

View on GitHub
Star
workspaces/cogito-ios-app/Cogito/Attestations service/OpenIDAttestationActions.swift

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Function Finish has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static func Finish(params: [String: String]) -> Thunk<AppState> {
        return Thunk { dispatch, getState in
            guard let idToken = params["id_token"] else {
                dispatch(FinishRejected(nonce: nil, error: "id token missing"))
                return
Severity: Minor
Found in workspaces/cogito-ios-app/Cogito/Attestations service/OpenIDAttestationActions.swift - About 1 hr to fix

    Function Finish has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        static func Finish(params: [String: String]) -> Thunk<AppState> {
        return Thunk { dispatch, getState in
            guard let idToken = params["id_token"] else {
                dispatch(FinishRejected(nonce: nil, error: "id token missing"))
                return
    Severity: Minor
    Found in workspaces/cogito-ios-app/Cogito/Attestations service/OpenIDAttestationActions.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function StartAttestation has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            for identity: Identity,
        requestId: JsonRpcId,
        oidcRealmUrl: URL,
        subject: String?,
        requestedOnChannel channelId: ChannelID? = nil) -> Thunk<AppState> {
    Severity: Minor
    Found in workspaces/cogito-ios-app/Cogito/Attestations service/OpenIDAttestationActions.swift - About 35 mins to fix

      Function GetAttestations has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          static func GetAttestations(requestId: JsonRpcId,
                                applicationName: String,
                                oidcRealmUrl: String,
                                subject: String?,
                                channel: TelepathChannel) -> Thunk<AppState> {
      Severity: Minor
      Found in workspaces/cogito-ios-app/Cogito/Attestations service/OpenIDAttestationActions.swift - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status