Sign upLogin

phinze/homebrew-cask

View on GitHub
Star
cmd/find-appcast.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method find_electron_builder has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def find_electron_builder(app)
        appcast_file = app.join("Contents/Resources/app-update.yml")
        return false unless appcast_file.exist?

        data = YAML.load_file(appcast_file)
Severity: Minor
Found in cmd/find-appcast.rb - About 1 hr to fix

    Method verify_appcast has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def verify_appcast(appcast_type, *urls)
        print "Looking for #{appcast_type} appcast: "
        urls.flatten.each do |url|
          next unless url_exist?(url)
    Severity: Minor
    Found in cmd/find-appcast.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status