phlipper/dead_letter_office

View on GitHub

Showing 2 of 2 total issues

Function fnUpdate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    "fnUpdate": function ( oSettings, fnDraw ) {
      var iListLength = 5;
      var oPaging = oSettings.oInstance.fnPagingInfo();
      var an = oSettings.aanFeatures.p;
      var i, j, sClass, iStart, iEnd, iHalf=Math.floor(iListLength/2);
Severity: Minor
Found in app/assets/javascripts/dead_letter_office/bootstrap_pagination.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fnUpdate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    "fnUpdate": function ( oSettings, fnDraw ) {
      var iListLength = 5;
      var oPaging = oSettings.oInstance.fnPagingInfo();
      var an = oSettings.aanFeatures.p;
      var i, j, sClass, iStart, iEnd, iHalf=Math.floor(iListLength/2);
Severity: Minor
Found in app/assets/javascripts/dead_letter_office/bootstrap_pagination.js - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language