phodal/echoesworks

View on GitHub

Showing 27 of 27 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else if ((calign[i].trimRight().slice(-1) === ':') && (strict !== true)) {
                if (calign[i][0] === ':') {
                    calign[i] = 3;
                } else {
                    calign[i] = 2;
Severity: Minor
Found in src/umarkdown.js and 1 other location - About 40 mins to fix
src/umarkdown.js on lines 118..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function tableHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    tableHandler: function (helper1, i, calign, replaceStr, cel) {
Severity: Minor
Found in src/umarkdown.js - About 35 mins to fix

    Function defaults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    EchoesWorks.defaults = function (obj) {
        if (!EchoesWorks.isObject(obj)) {
            return obj;
        }
    
    
    Severity: Minor
    Found in src/utils.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function send has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    EchoesWorks.send = function (url, method, callback, data) {
        data = data || null;
        var request = new XMLHttpRequest();
        if (callback instanceof Function) {
            request.onreadystatechange = function () {
    Severity: Minor
    Found in src/ajax.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function extend has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    EchoesWorks.extend = function (obj) {
        if (!EchoesWorks.isObject(obj)) {
            return obj;
        }
        var source, prop;
    Severity: Minor
    Found in src/utils.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function listHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        listHandler: function (line, nstatus, status, replaceStr, helper1, casca) {
            var indent = false;
            if ((line[2] === undefined) || (line[2].length === 0)) {
                nstatus = 0;
            } else {
    Severity: Minor
    Found in src/umarkdown.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        parse: function (str, strict) {
            var helper, helper1, stra, trashgc = [], i, that = this, regexObject = micromarkdown.regexobject;
            regexObject.lists = this.listStrict(strict, regexObject);
    
            str = '\n' + str + '\n';
    Severity: Minor
    Found in src/umarkdown.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language