Sign upLogin

phossa2/db

View on GitHub
Star

Showing 5 of 5 total issues

Missing class import via use statement (line '106', column '21').
Open

        $link = new \mysqli();
Severity: Minor
Found in src/Db/Driver/Mysqli/Driver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '107', column '21').
Open

        $link = new \PDO(
Severity: Minor
Found in src/Db/Driver/Pdo/Driver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function getOneRow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getOneRow()
    {
        if ($this->bindResult()) {
            if ($this->statement->fetch()) {
                $row = [];
Severity: Minor
Found in src/Db/Driver/Mysqli/Result.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$name'.
Open

        foreach ($parameters as $name => &$value) {
Severity: Minor
Found in src/Db/Driver/Mysqli/Statement.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The 'getFields()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    protected function getFields()/*# : bool */
    {
        if (null === $this->cols) {
            $result = $this->statement->result_metadata();
            if (false === $result) {
Severity: Minor
Found in src/Db/Driver/Mysqli/Result.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Severity
Category
Status
Source
Language