phossa2/logger

View on GitHub

Showing 9 of 9 total issues

Avoid using undefined variables such as '$levels' which will lead to PHP notices.
Open

                LogLevel::$levels[$data['extra']]) {

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$levels' which will lead to PHP notices.
Open

        if (!isset(LogLevel::$levels[$level])) {
Severity: Minor
Found in src/Logger/Logger.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$levels' which will lead to PHP notices.
Open

            if (LogLevel::$levels[$logEntry->getLevel()] >=

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$levels' which will lead to PHP notices.
Open

        if (!isset(LogLevel::$levels[$level])) {
Severity: Minor
Found in src/Logger/Entry/LogEntry.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        /*# string */ $channel,
        /*# string */ $level,
        /*# string */ $message,
        array $context = [],
        /*# float */ $timestamp = 0
Severity: Minor
Found in src/Logger/Entry/LogEntry.php - About 35 mins to fix

    Method addCallable has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            /*# string */ $type,
            callable $callable,
            /*# string */ $channel,
            /*# int */ $priority,
            /*# string */ $level = ''
    Severity: Minor
    Found in src/Logger/Traits/ExtendedLoggerTrait.php - About 35 mins to fix

      Function removeFromQueue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function removeFromQueue(
              PriorityQueueInterface $queue,
              $callabOrClassname
          ) {
              if (is_object($callabOrClassname)) {
      Severity: Minor
      Found in src/Logger/Traits/ExtendedLoggerTrait.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function runHandlers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function runHandlers(LogEntryInterface $logEntry)
          {
              // get related handlers
              $queue = $this->getCallables('handlers', $logEntry->getChannel());
      
      
      Severity: Minor
      Found in src/Logger/Traits/ExtendedLoggerTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused parameters such as '$logEntry'.
      Open

          protected function isHandling(LogEntryInterface $logEntry)/*# : bool */

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Severity
      Category
      Status
      Source
      Language