Sign upLogin

phossa2/middleware

View on GitHub
Star

Showing 5 of 5 total issues

Method setCookie has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ResponseInterface $response,
        /*# string */ $name,
        /*# string */ $value = null,
        /*# int */ $ttl = null,
        /*# string */ $path = null,
Severity: Major
Found in src/Middleware/Utility.php - About 1 hr to fix

    Missing class import via use statement (line '62', column '28').
    Open

            $this->queue = new \SplQueue();
    Severity: Minor
    Found in src/Middleware/Queue.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Function evaluate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function evaluate(
        RequestInterface $request,
        ResponseInterface $response
    )/*# : bool */ {
        foreach ($this->conditions as $cond) {
    Severity: Minor
    Found in src/Middleware/Condition/MultipleCondition.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused parameters such as '$request'.
    Open

            RequestInterface $request,
    Severity: Minor
    Found in src/Middleware/Middleware/MiddlewareAbstract.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$request'.
    Open

            RequestInterface $request,
    Severity: Minor
    Found in src/Middleware/Middleware/MiddlewareAbstract.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Severity
    Category
    Status
    Source
    Language