Sign upLogin

phossa2/query

View on GitHub
Star

Showing 13 of 13 total issues

The class Builder has 12 public methods. Consider refactoring Builder to keep number of public methods under 10.
Open

class Builder extends ObjectAbstract implements BuilderInterface
{
    use DialectAwareTrait, SettingsAwareTrait, ParameterAwareTrait;

    /**
Severity: Minor
Found in src/Query/Builder.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Avoid using short method names like OnTrait::on(). The configured minimum method name length is 3.
Open

    public function on(
        $firstTableCol,
        /*# string */ $operator = ClauseInterface::NO_OPERATOR,
        /*# string */ $secondTableCol = ClauseInterface::NO_VALUE
    ) {
Severity: Minor
Found in src/Query/Traits/Clause/OnTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like OnInterface::on(). The configured minimum method name length is 3.
Open

    public function on(
        $firstTableCol,
        /*# string */ $operator = ClauseInterface::NO_OPERATOR,
        /*# string */ $secondTableCol = ClauseInterface::NO_VALUE
    );
Severity: Minor
Found in src/Query/Interfaces/Clause/OnInterface.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method realWhere has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $col,
        $operator = WhereInterface::NO_OPERATOR,
        $value = WhereInterface::NO_VALUE,
        /*# bool */ $logicAnd = true,
        /*# bool */ $whereNot = false,
Severity: Major
Found in src/Query/Traits/Clause/HavingTrait.php - About 50 mins to fix

    Method realWhere has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $col,
        $operator = WhereInterface::NO_OPERATOR,
        $value = WhereInterface::NO_VALUE,
        /*# string */ $logicAnd = 'AND',
        /*# string */ $whereNot = '',
    Severity: Major
    Found in src/Query/Traits/Clause/WhereTrait.php - About 50 mins to fix

      Function buildUpdateSet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function buildUpdateSet(
        /*# string */ $prefix,
        array $settings
    )/*# : string */ {
        $result = [];
      Severity: Minor
      Found in src/Query/Traits/Clause/SetTrait.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setWithArrayData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function setWithArrayData(array $data)
    {
        if (isset($data[0])) { // multiple rows
            foreach ($data as $row) {
                $this->set($row);
      Severity: Minor
      Found in src/Query/Traits/Clause/SetTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function realCol has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function realCol(
        $col,
        /*# string */ $alias = '',
        $rawMode = false
    ) {
      Severity: Minor
      Found in src/Query/Traits/Clause/ColTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setEscapeCallable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function setEscapeCallable($escapeFunction)/*# : callable */
    {
        if (!is_callable($escapeFunction)) {
            $this->escape = function ($v) {
                if (is_numeric($v) && !is_string($v)) {
      Severity: Minor
      Found in src/Query/Misc/Parameter.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused parameters such as '$settings'.
      Open

              array $settings
      Severity: Minor
      Found in src/Query/Traits/Clause/ColTrait.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Avoid unused parameters such as '$prefix'.
      Open

              /*# string */ $prefix,
      Severity: Minor
      Found in src/Query/Traits/Clause/SetTrait.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Avoid unused local variables such as '$clause'.
      Open

              $clause = &$this->getClause('TABLE');
      Severity: Minor
      Found in src/Query/Traits/Clause/TableTrait.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$clause'.
      Open

              $clause = &$this->getClause('LIMIT');
      Severity: Minor
      Found in src/Query/Traits/Clause/LimitTrait.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Severity
      Category
      Status
      Source
      Language