Sign upLogin

phossa2/shared

View on GitHub
Star

Showing 21 of 21 total issues

Avoid using undefined variables such as '::$mappings' which will lead to PHP notices.
Open

            return self::$mappings[get_called_class()];
Severity: Minor
Found in src/Shared/Message/Mapping/MappingTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$messages' which will lead to PHP notices.
Open

        return isset(static::$messages[$code]);
Severity: Minor
Found in src/Shared/Message/Mapping/MappingTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$shareables' which will lead to PHP notices.
Open

        return self::$shareables[get_called_class()][$scope];
Severity: Minor
Found in src/Shared/Shareable/ShareableTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$loaders' which will lead to PHP notices.
Open

        return self::$loaders[get_called_class()];
Severity: Minor
Found in src/Shared/Message/Loader/LoaderAwareTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$shareables' which will lead to PHP notices.
Open

        return isset(self::$shareables[get_called_class()][$scope]);
Severity: Minor
Found in src/Shared/Shareable/ShareableTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$loaders' which will lead to PHP notices.
Open

            unset(self::$loaders[$class]);
Severity: Minor
Found in src/Shared/Message/Loader/LoaderAwareTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$loaders' which will lead to PHP notices.
Open

        if (isset(self::$loaders[$class])) {
Severity: Minor
Found in src/Shared/Message/Loader/LoaderAwareTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$shareables' which will lead to PHP notices.
Open

        if (isset(self::$shareables[get_called_class()])) {
Severity: Minor
Found in src/Shared/Shareable/ShareableTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$shareables' which will lead to PHP notices.
Open

            return array_keys(self::$shareables[get_called_class()]);
Severity: Minor
Found in src/Shared/Shareable/ShareableTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$mappings' which will lead to PHP notices.
Open

        return isset(self::$mappings[get_called_class()]);
Severity: Minor
Found in src/Shared/Message/Mapping/MappingTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Missing class import via use statement (line '65', column '26').
Open

            $class = new \ReflectionClass($className);
Severity: Minor
Found in src/Shared/Message/Loader/LanguageLoader.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 32.
Open

    protected static function readFromFile($path)
    {
        return @parse_ini_file($path, true);
    }
Severity: Minor
Found in src/Shared/Reader/IniReader.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 32.
Open

    protected static function readFromFile($path)
    {
        return @unserialize(file_get_contents($path));
    }
Severity: Minor
Found in src/Shared/Reader/SerializedReader.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 32.
Open

    protected static function readFromFile($path)
    {
        $data = @simplexml_load_file($path);
        return $data ? @json_decode(json_encode($data), true) : false;
    }
Severity: Minor
Found in src/Shared/Reader/XmlReader.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '137', column '20').
Open

        return new \ArrayIterator($this->queue);
Severity: Minor
Found in src/Shared/Queue/PriorityQueueTrait.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 33.
Open

    protected static function readFromFile($path)
    {
        $data = @simplexml_load_file($path);
        return $data ? @json_decode(json_encode($data), true) : false;
    }
Severity: Minor
Found in src/Shared/Reader/XmlReader.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 48.
Open

    protected static function readFromFile($path)
    {
        return @json_decode(file_get_contents($path), true);
    }
Severity: Minor
Found in src/Shared/Reader/JsonReader.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Function loadMessages has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadMessages(
        /*# string */ $className
    )/*# : array */ {
        $map = [];
        if (class_exists($className)) {
Severity: Minor
Found in src/Shared/Message/Loader/LanguageLoader.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function removeFromLookup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function removeFromLookup($registry)
    {
        foreach ($this->lookup_pool as $idx => $reg) {
            if ($registry === $reg) {
                if ($reg instanceof DelegatorAwareInterface) {
Severity: Minor
Found in src/Shared/Delegator/DelegatorTrait.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$path'.
Open

    protected static function readFromFile($path)
Severity: Minor
Found in src/Shared/Reader/ReaderAbstract.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language