Sign upLogin

php-vivace/db

View on GitHub
Star

Showing 71 of 71 total issues

Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute()
    {
        if (!$this->stmt) {
            if ($this->params) {
                $this->stmt = $this->PDO->prepare($this->sql);
Severity: Minor
Found in src/sql/PostgreSQL/Fetcher.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute()
    {
        if (!$this->stmt) {
            if ($this->params) {
                $this->stmt = $this->PDO->prepare($this->sql);
Severity: Minor
Found in src/sql/MySQL/Fetcher.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function update(array &$stack, Statement\Update $statement)
    {
        self::literal($stack, 'UPDATE ');
        if ($statement->offset) {
            self::identifier($stack, $statement->source);
Severity: Major
Found in src/sql/MySQL/Driver.php - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    case 'or':
                    $expressions = array_slice($statement, 2);
                    self::literal($stack, '(');
                    self::condition($stack, $statement[1]);
                    $word = $statement[0] === 'and' ? 'AND' : 'OR';
    Severity: Major
    Found in src/sql/PostgreSQL/Driver.php and 1 other location - About 2 hrs to fix
    src/sql/MySQL/Driver.php on lines 497..507

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    case 'or':
                    $expressions = array_slice($statement, 2);
                    self::literal($stack, '(');
                    self::condition($stack, $statement[1]);
                    $word = $statement[0] === 'and' ? 'AND' : 'OR';
    Severity: Major
    Found in src/sql/MySQL/Driver.php and 1 other location - About 2 hrs to fix
    src/sql/PostgreSQL/Driver.php on lines 477..487

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function update has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function update(array &$stack = [], Statement\Update $statement)
    {
        self::literal($stack, 'UPDATE ');
        self::identifier($stack, $statement->source);
        self::literal($stack, ' SET ');
    Severity: Minor
    Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function delete has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function delete(array &$stack, Statement\Delete $statement)
    {
        if ($statement->offset) {
    Severity: Minor
    Found in src/sql/MySQL/Driver.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($statement->values as $i => $values) {
            if ($i) self::literal($stack, ', ');
            self::literal($stack, ' (');
            foreach ($values as $j => $value) {
                if ($j) self::literal($stack, ', ');
    Severity: Major
    Found in src/sql/PostgreSQL/Driver.php and 1 other location - About 1 hr to fix
    src/sql/MySQL/Driver.php on lines 174..186

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($statement->values as $i => $values) {
            if ($i) self::literal($stack, ', ');
            self::literal($stack, ' (');
            foreach ($values as $j => $value) {
                if ($j) self::literal($stack, ', ');
    Severity: Major
    Found in src/sql/MySQL/Driver.php and 1 other location - About 1 hr to fix
    src/sql/PostgreSQL/Driver.php on lines 209..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method update has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function update(array &$stack = [], Statement\Update $statement)
    {
        self::literal($stack, 'UPDATE ');
        self::identifier($stack, $statement->source);
        self::literal($stack, ' SET ');
    Severity: Minor
    Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

      Function getIterator has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getIterator()
    {
        if ($this->relation) {
            $items = [];
            $total = $this->fetcher->count() - 1;
      Severity: Minor
      Found in src/sql/Reader.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function save(array $data): bool
    {
        $columns = [];
        $values = [];
      Severity: Minor
      Found in src/sql/Storage.php - About 1 hr to fix

        Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute(Statement\Modifier $query): Result
    {
        [$sql, $params] = $this->build($query);
        if ($params) {
            $stmt = $this->pdo->prepare($sql);
        Severity: Minor
        Found in src/sql/MySQL/Driver.php - About 1 hr to fix

          Method delete has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function delete(array &$stack, Statement\Delete $statement)
    {
        if ($statement->offset) {
          Severity: Minor
          Found in src/sql/MySQL/Driver.php - About 1 hr to fix

            Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function execute(Statement\Modifier $query): Result
    {

        [$sql, $params] = $this->build($query);
        if ($params) {
            Severity: Minor
            Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

              Method insert has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function insert(array &$stack, Statement\Insert $statement)
    {
        self::literal($stack, 'INSERT INTO ');
        self::identifier($stack, $statement->source);
        self::literal($stack, ' (');
              Severity: Minor
              Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

                Method delete has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function delete(array &$stack, Statement\Delete $statement)
    {
        if ($statement->offset || $statement->order || $statement->limit) {
                Severity: Minor
                Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

                  Method insert has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function insert(array &$stack, Statement\Insert $statement)
    {
        self::literal($stack, 'INSERT INTO ');
        self::identifier($stack, $statement->source);
        self::literal($stack, ' (');
                  Severity: Minor
                  Found in src/sql/MySQL/Driver.php - About 1 hr to fix

                    Function count has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function count(array &$stack, Statement\Count $statement)
    {
        if ($statement->limit || $statement->offset || $statement->order || $statement->join) {
            self::literal($stack, 'SELECT COUNT(*) FROM (');
            $sub = new Statement\Select($statement->source);
                    Severity: Minor
                    Found in src/sql/PostgreSQL/Driver.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function update(array $data): int
    {
        $schema = $this->storage()->schema();
        $query = new Update($this->storage()->getSource(), $data);
                    Severity: Minor
                    Found in src/sql/Finder.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language