Sign upLogin

php-yaoi/php-yaoi

View on GitHub
Star

Showing 203 of 203 total issues

Function tokenize has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    public function tokenize($string)
    {
        $result = $mainResult = new Parsed();

        /** @var Quote $quoteStarted */
Severity: Minor
Found in src/String/Lexer/Parser.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tokenize has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function tokenize($string)
    {
        $quoteStarted = false;
        $escape = array();
        $start = false;
Severity: Minor
Found in src/String/Tokenizer.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function build(Quoter $quoter = null)
    {
        if ($this->isEmpty()) {
            return '';
        }
Severity: Minor
Found in src/Sql/Expression.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function build(Quoter $quoter = null) {
        if ($this->binds) {
            if ($quoter === null && $this->quoter !== null) {
                $quoter = $this->quoter;
            }
Severity: Minor
Found in src/String/Expression.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchAll has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function fetchAll($keyField = null, $valueField = null)
    {
        if (!$this->executed) {
            $this->execute();
        }
Severity: Minor
Found in src/Database/Query.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function processForeignKeys()
    {
        /** @var ForeignKey[] $beforeForeignKeys */
        $beforeForeignKeys = array();
        if (!$this->before->disableForeignKeys) {
Severity: Major
Found in src/Sql/AlterTable.php and 1 other location - About 4 hrs to fix
src/Database/Pgsql/AlterTable.php on lines 93..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function processForeignKeys()
    {
        /** @var ForeignKey[] $beforeForeignKeys */
        $beforeForeignKeys = array();
        if (!$this->before->disableForeignKeys) {
Severity: Major
Found in src/Database/Pgsql/AlterTable.php and 1 other location - About 4 hrs to fix
src/Sql/AlterTable.php on lines 104..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function findOrCreateInstance has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    private static function findOrCreateInstance($serviceClassName, $identifier, $idIsSettings = false) {
        //var_dump('=-=-=-=-=-=-=-=-=-=-=-=-=-=',$serviceClassName, $identifier, $idIsSettings);

        if ($identifier instanceof Closure) {
            $identifier = self::resolveClosure($identifier);
Severity: Minor
Found in src/Service.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeAnchor has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeAnchor(State $commandState)
    {
        $commandClass = $commandState->commandClass;
        $commandClasses = array();
        if ($commandClass !== $this->definition->commandClass) {
Severity: Minor
Found in src/Command/Io.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetch has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function fetch($url = null)
    {
        if (null !== $url) {
            if (strpos($url, '://') === false) {
                $url = $this->getAbsoluteUrl($url);
Severity: Minor
Found in src/Http/Client.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tokenize has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function tokenize($string)
    {
        $result = $mainResult = new Parsed();

        /** @var Quote $quoteStarted */
Severity: Major
Found in src/String/Lexer/Parser.php - About 4 hrs to fix

    File Client.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace Yaoi\Http;

use Yaoi\Http\Client\Driver;
use Yaoi\Http\Client\Settings;
    Severity: Minor
    Found in src/Http/Client.php - About 4 hrs to fix

      Function processColumns has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function processColumns()
    {
        $beforeColumns = $this->before->getColumns(true, true);
        foreach ($this->after->getColumns(true, true) as $columnName => $afterColumn) {
            $afterTypeString = $afterColumn->getTypeString();
      Severity: Minor
      Found in src/Database/Pgsql/AlterTable.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function render()
    {
        if ($this->withJsonZoom) {
            $this->addCallbackOption('xAxis', 'events', 'afterSetExtremes', 'loadPoints');
            $this->addCallbackOption('xAxis', 'events', 'setExtremes', 'setExtremesCallback');
      Severity: Major
      Found in src/View/HighCharts.php - About 3 hrs to fix

        Function echoLines has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

            public function echoLines()
    {
        foreach ($this->lines as $rowIndex => $rowData) {
            foreach ($rowData as $lineIndex => $row) {
                $line = '';
        Severity: Minor
        Found in src/Cli/View/Table.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findSaved has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

            public function findSaved()
    {
        $table = $this->table();
        $statement = self::statement();
        $data = $this->toArray(true);
        Severity: Minor
        Found in src/Database/Entity.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function varExportString has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

            public function varExportString($string, $usePhpEol = true) {
        static $specialChars = array(
            "\r" => '\r',
            "\n" => '\n',
            "\t" => '\t',
        Severity: Minor
        Found in src/Test/PHPUnit/TestCase.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File HighCharts.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace Yaoi\View;

use Yaoi\BaseClass;
        Severity: Minor
        Found in src/View/HighCharts.php - About 3 hrs to fix

          Function strPos has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function strPos($haystack, $needles, $offset = 0, $reverse = false, $ignoreCase = false)
    {
        self::$strPosLastFound = null;
        $result = false;
        if (!is_array($needles)) {
          Severity: Minor
          Found in src/String/Utils.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getColumns has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getColumns($tableName) {
        //echo PHP_EOL . 'table: ' . $tableName . PHP_EOL;
        $res = $this->database
            ->select()
            ->select('c.column_name, c.is_nullable, c.data_type, c.column_default, tc.constraint_type')
          Severity: Minor
          Found in src/Database/Pgsql/SchemaReader.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language