File admin_controller.php has 405 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
*
* Board Rules extension for the phpBB Forum Software package.
*

Method add_edit_rule_data has 113 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function add_edit_rule_data($entity, $data)
    {
        // Get form's POST actions (submit or preview)
        $submit = $this->request->is_set_post('submit');
        $preview = $this->request->is_set_post('preview');

Function add_edit_rule_data has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.

Open

    protected function add_edit_rule_data($entity, $data)
    {
        // Get form's POST actions (submit or preview)
        $submit = $this->request->is_set_post('submit');
        $preview = $this->request->is_set_post('preview');

• Read up
  Read up

The class rule has 14 public methods. Consider refactoring rule to keep number of public methods under 10.

Open

class rule implements rule_interface
{
    /**
    * Data for this entity
    *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class rule has an overall complexity of 67 which is very high. The configured complexity threshold is 50.

Open

class rule implements rule_interface
{
    /**
    * Data for this entity
    *

• Exclude checks
  • Disable engine
  • Disable check

rule has 28 functions (exceeds 20 allowed). Consider refactoring.

Open

class rule implements rule_interface
{
    /**
    * Data for this entity
    *

The class admin_controller has an overall complexity of 65 which is very high. The configured complexity threshold is 50.

Open

class admin_controller implements admin_interface
{
    /** @var \phpbb\config\config */
    protected $config;

• Exclude checks
  • Disable engine
  • Disable check

Method display has 70 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function display()
    {
        // When board rules are disabled, redirect users back to the forum index
        if (empty($this->config['boardrules_enable']))
        {

File rule.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
*
* Board Rules extension for the phpBB Forum Software package.
*

Method main has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function main($id, $mode)
    {
        global $phpbb_container;

        /** @var \phpbb\language\language $lang */

Function display has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

    public function display()
    {
        // When board rules are disabled, redirect users back to the forum index
        if (empty($this->config['boardrules_enable']))
        {

• Read up
  Read up

Method import has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function import($data)
    {
        // Clear out any saved data
        $this->data = array();

Avoid excessively long variable names like $message_parse_options. Keep variable name length under 20.

Open

        $message_parse_options = array(

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $boardrules_list_style. Keep variable name length under 20.

Open

        $boardrules_list_style = $this->request->variable('boardrules_list_style', '');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct(\phpbb\config\config $config, ContainerInterface $container, \phpbb\controller\helper $controller_helper, \phpbb\db\driver\driver_interface $db, \phpbb\language\language $lang, \phpbb\log\log $log, \phpbb\notification\manager $notification_manager, \phpbb\request\request $request, \phpbb\boardrules\operators\rule $rule_operator, \phpbb\template\template $template, \phpbb\user $user, $root_path, $php_ext)

Function main has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    public function main($id, $mode)
    {
        global $phpbb_container;

        /** @var \phpbb\language\language $lang */

• Read up
  Read up

Method display_rules has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function display_rules($language, $parent_id = 0)
    {
        // Grab all the rules in the current user's language
        $entities = $this->rule_operator->get_rules($language, $parent_id);

Method display_options has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function display_options()
    {
        // Create a form key for preventing CSRF attacks
        add_form_key('boardrules_settings');

Method insert_sample_rule_data has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function insert_sample_rule_data()
    {
        /** @var \phpbb\user $user */
        $user = $this->container->get('user');

Method set_anchor has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function set_anchor($anchor)
    {
        // Enforce a string
        $anchor = (string) $anchor;