Sign upLogin

phpexpertsinc/ColorSpeaker

View on GitHub
Star

Showing 6 of 6 total issues

Method toRGB has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toRGB(): RGBColor
    {
        /**
         * Taken from https://stackoverflow.com/a/40492904/430062 with a few mods.
         *
Severity: Minor
Found in src/internal/HSLSpeaker.php - About 1 hr to fix

    Method fromRGB has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function fromRGB(int $red, int $green, int $blue): ColorSpeakerContract
    {
        // Convert to an RGBColor first to ensure it is, indeed, a valid RGB Color.
        $rgbColor = new RGBColor(['red' => $red, 'green' => $green, 'blue' => $blue]);
    Severity: Minor
    Found in src/internal/HSLSpeaker.php - About 1 hr to fix

      Function toRGB has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toRGB(): RGBColor
    {
        /**
         * Taken from https://stackoverflow.com/a/40492904/430062 with a few mods.
         *
      Severity: Minor
      Found in src/internal/HSLSpeaker.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct(array $input, array $options = [self::PERMISSIVE], DataTypeValidator $validator = null)
    {
        if (!$validator) {
            $isA = new IsAFuzzyDataType();
            $validator = new DataTypeValidator($isA);
      Severity: Minor
      Found in src/DTOs/HSLColor.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fromRGB has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function fromRGB(int $red, int $green, int $blue): ColorSpeakerContract
    {
        // Convert to an RGBColor first to ensure it is, indeed, a valid RGB Color.
        $rgbColor = new RGBColor(['red' => $red, 'green' => $green, 'blue' => $blue]);
      Severity: Minor
      Found in src/internal/HSLSpeaker.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extraValidation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function extraValidation(array $input)
    {
        $reasons = [];
        if ($input['hue'] < self::HUE_MIN || $input['hue'] > self::HUE_MAX) {
            $reasons['hue'] = sprintf(
      Severity: Minor
      Found in src/DTOs/HSLColor.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language