libs/compiler/src/Node/Definition/TokenDefinitionNode.php
The method __construct has a boolean flag argument $keep, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public bool $keep = true,- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Arguments with default values must be at the end of the argument list Open
Open
public bool $keep = true,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public string $name,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public bool $keep = true,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public string $value,- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks