phplrt/phplrt

View on GitHub
libs/lexer/src/Runtime/CompiledExecutor.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Fiber' in method 'run'.
Open

            \Fiber::getCurrent() && \Fiber::suspend();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method composite uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                if (\is_int($index)) {
                    --$index;
                }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Fiber' in method 'run'.
Open

            \Fiber::getCurrent() && \Fiber::suspend();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fiber' in method 'run'.
Open

        \Fiber::getCurrent() && \Fiber::suspend();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fiber' in method 'run'.
Open

        \Fiber::getCurrent() && \Fiber::suspend();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Line exceeds 120 characters; contains 129 characters
Open

    private function composite(int|string $name, array $payload, int $offset, ChannelInterface $channel): CompositeTokenInterface

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly string $pattern,

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly array $skip,

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly string $unknown,

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly bool $composite,

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly array $aliases,

Closing brace must be on a line by itself
Open

    ) {}

There are no issues that match your filters.

Category
Status