The class Executor has an overall complexity of 57 which is very high. The configured complexity threshold is 50. Open
class Executor implements ExecutorInterface
{
/**
* @var int
*/- Exclude checks
The method traverseNode() has an NPath complexity of 239. The configured NPath complexity threshold is 200. Open
protected function traverseNode(NodeInterface $node): NodeInterface
{
foreach ($node as $name => $child) {
if (\is_array($child)) {
$this->updateNodeValue($node, $name, $this->traverseArray($child));- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method traverseArray() has an NPath complexity of 945. The configured NPath complexity threshold is 200. Open
protected function traverseArray(array $nodes): array
{
$replacements = [];
foreach ($nodes as $i => &$node) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method traverseArray() has 102 lines of code. Current threshold is set to 100. Avoid really long methods. Open
protected function traverseArray(array $nodes): array
{
$replacements = [];
foreach ($nodes as $i => &$node) {- Exclude checks
The method traverseNode() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10. Open
protected function traverseNode(NodeInterface $node): NodeInterface
{
foreach ($node as $name => $child) {
if (\is_array($child)) {
$this->updateNodeValue($node, $name, $this->traverseArray($child));- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method traverseArray() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10. Open
protected function traverseArray(array $nodes): array
{
$replacements = [];
foreach ($nodes as $i => &$node) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid assigning values to variables in if clauses and the like (line '149', column '18'). Open
private function before(iterable $nodes): iterable
{
foreach ($this->visitors as $visitor) {
if (($result = $visitor->before($nodes)) !== null) {
$nodes = $result;- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '421', column '18'). Open
private function after(iterable $nodes): iterable
{
foreach ($this->visitors as $visitor) {
if (($result = $visitor->after($nodes)) !== null) {
$nodes = $result;- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Arguments with default values must be at the end of the argument list Open
private readonly array $visitors = [],- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly array $visitors = [],- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks