Sign upLogin

phplrt/phplrt

View on GitHub
Star
libs/visitor/src/Traverser.php

Summary

Maintainability
A
0 mins
Test Coverage

The method with has a boolean flag argument $prepend, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function with(VisitorInterface $visitor, bool $prepend = false): TraverserInterface
Severity: Minor
Found in libs/visitor/src/Traverser.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid variables with short names like $fn. Configured minimum length is 3.
Open

        $fn = $prepend ? '\\array_unshift' : '\\array_push';
Severity: Minor
Found in libs/visitor/src/Traverser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Opening brace should be on a new line
Open

    final public function __construct(private array $visitors = []) {}
Severity: Minor
Found in libs/visitor/src/Traverser.php by phpcodesniffer

Closing brace must be on a line by itself
Open

    final public function __construct(private array $visitors = []) {}
Severity: Minor
Found in libs/visitor/src/Traverser.php by phpcodesniffer

There are no issues that match your filters.

Category
Status