Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star

Showing 2,025 of 2,025 total issues

Method getNames has 377 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function getNames(): array
    {
        /** @var array<string, string> $namesMap */
        static $namesMap = [];
Severity: Major
Found in src/Config/Descriptions.php - About 1 day to fix

    File Config.php has 771 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace PhpMyAdmin;
    Severity: Major
    Found in src/Config.php - About 1 day to fix

      File normalization.ts has 767 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import $ from 'jquery';
import { AJAX } from './modules/ajax.ts';
import { Functions } from './modules/functions.ts';
import { CommonParams } from './modules/common.ts';
import { ajaxShowMessage } from './modules/ajax-message.ts';
      Severity: Major
      Found in resources/js/src/normalization.ts - About 1 day to fix

        File Generator.php has 747 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * HTML Generator
 */
        Severity: Major
        Found in src/Html/Generator.php - About 1 day to fix

          Function exportDatabase has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
          Open

              public function exportDatabase(
        DatabaseName $db,
        array $tables,
        string $whatStrucOrData,
        array $tableStructure,
          Severity: Minor
          Found in src/Export/Export.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function doImport has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
          Open

              public function doImport(File|null $importHandle = null): array
    {
        $GLOBALS['error'] ??= null;

        $sqlStatements = [];
          Severity: Minor
          Found in src/Plugins/Import/ImportMediawiki.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (data.errors) {
            $('<div></div>', { id: 'pma_errors', class: 'clearfloat d-print-none' })
                .insertAfter('#selflink')
                .append(data.errors);
          Severity: Major
          Found in resources/js/src/modules/ajax.ts and 1 other location - About 1 day to fix
          resources/js/src/modules/ajax.ts on lines 600..630

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 298.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (data.errors) {
                    $('<div></div>', { id: 'pma_errors', class: 'clearfloat d-print-none' })
                        .insertAfter('#selflink')
                        .append(data.errors);
          Severity: Major
          Found in resources/js/src/modules/ajax.ts and 1 other location - About 1 day to fix
          resources/js/src/modules/ajax.ts on lines 395..425

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 298.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function reload has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
          Open

          const reload = function () {
    DesignerMove.resizeOsnTab();
    var n;
    var x1;
    var x2;
          Severity: Minor
          Found in resources/js/src/designer/move.ts - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setProperties has 304 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function setProperties(): ExportPluginProperties
    {
        $GLOBALS['plugin_param'] ??= null;

        $hideSql = false;
          Severity: Major
          Found in src/Plugins/Export/ExportSql.php - About 1 day to fix

            Function replaceWithAliases has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
            Open

                public function replaceWithAliases(
        string|null $delimiter,
        string $sqlQuery,
        array $aliases,
        string $db,
            Severity: Minor
            Found in src/Plugins/Export/ExportSql.php - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function queryFrom has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
            Open

            const queryFrom = function () {
    var i;
    var tabLeft = [];
    var tabUsed = [];
    var tTabLeft = [];
            Severity: Minor
            Found in resources/js/src/designer/history.ts - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File routines.ts has 663 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import $ from 'jquery';
import { AJAX } from '../modules/ajax.ts';
import { Functions } from '../modules/functions.ts';
import { Navigation } from '../modules/navigation.ts';
import { ajaxRemoveMessage, ajaxShowMessage } from '../modules/ajax-message.ts';
            Severity: Major
            Found in resources/js/src/database/routines.ts - About 1 day to fix

              File change.ts has 653 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import $ from 'jquery';
import { AJAX } from '../modules/ajax.ts';
import { Functions } from '../modules/functions.ts';

/**
              Severity: Major
              Found in resources/js/src/table/change.ts - About 1 day to fix

                File CentralColumns.php has 641 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

declare(strict_types=1);

namespace PhpMyAdmin\Database;
                Severity: Major
                Found in src/Database/CentralColumns.php - About 1 day to fix

                  File Operations.php has 640 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

declare(strict_types=1);

namespace PhpMyAdmin;
                  Severity: Major
                  Found in src/Operations.php - About 1 day to fix

                    File history.ts has 633 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import $ from 'jquery';
import { Functions } from '../modules/functions.ts';
import getImageTag from '../modules/functions/getImageTag.ts';
import { DesignerConfig } from './config.ts';
                    Severity: Major
                    Found in resources/js/src/designer/history.ts - About 1 day to fix

                      Function showEditArea has 278 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              showEditArea: function () {
            if (! g.isCellEditActive) {   // make sure the edit area has not been shown
                g.isCellEditActive = true;
                g.isEditCellTextEditable = false;
                /**
                      Severity: Major
                      Found in resources/js/src/makegrid.ts - About 1 day to fix

                        File ajax.ts has 627 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        import $ from 'jquery';
import { Navigation } from './navigation.ts';
import { CommonParams } from './common.ts';
import highlightSql from './sql-highlight.ts';
import { ajaxRemoveMessage, ajaxShowMessage } from './ajax-message.ts';
                        Severity: Major
                        Found in resources/js/src/modules/ajax.ts - About 1 day to fix

                          Method collect has 267 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public static function collect(RouteCollector $routes): void
    {
        $routes->addRoute(['GET', 'POST'], '[/]', HomeController::class);
        $routes->addRoute(['GET', 'POST'], '/browse-foreigners', BrowseForeignersController::class);
        $routes->get('/changelog', ChangeLogController::class);
                          Severity: Major
                          Found in src/Routing/Routes.php - About 1 day to fix
                            Severity
                            Category
                            Status
                            Source
                            Language