Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
resources/js/src/drag_drop_import.ts

Summary

Maintainability
C
1 day
Test Coverage

Function sendFileToServer has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    sendFileToServer: function (formData, hash): void {
        var jqXHR = $.ajax({
            xhr: function () {
                var xhrobj = $.ajaxSettings.xhr();
                if (xhrobj.upload) {
Severity: Major
Found in resources/js/src/drag_drop_import.ts - About 2 hrs to fix

    Function drop has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        drop: function (event): void {
        // We don't want to prevent users from using
        // browser's default drag-drop feature on some page(s)
        if ($('.noDragDrop').length !== 0) {
            return;
    Severity: Major
    Found in resources/js/src/drag_drop_import.ts - About 2 hrs to fix

      Function drop has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          drop: function (event): void {
        // We don't want to prevent users from using
        // browser's default drag-drop feature on some page(s)
        if ($('.noDragDrop').length !== 0) {
            return;
      Severity: Minor
      Found in resources/js/src/drag_drop_import.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function importFinished has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          importFinished: function (hash, aborted, status): void {
        $('.pma_sql_import_status div li[data-hash="' + hash + '"]')
            .children('progress').hide();

        var icon = 'icon ic_s_success';
      Severity: Minor
      Found in resources/js/src/drag_drop_import.ts - About 1 hr to fix

        Function importFinished has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            importFinished: function (hash, aborted, status): void {
        $('.pma_sql_import_status div li[data-hash="' + hash + '"]')
            .children('progress').hide();

        var icon = 'icon ic_s_success';
        Severity: Minor
        Found in resources/js/src/drag_drop_import.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            } else {
        $('.pma_sql_import_status div').css('height', '0px');
        $(this).attr('toggle', 'off');
        $(this).html('+');  // to maximise
    }
        Severity: Minor
        Found in resources/js/src/drag_drop_import.ts and 1 other location - About 50 mins to fix
        resources/js/src/drag_drop_import.ts on lines 368..372

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ($(this).attr('toggle') === 'off') {
        $('.pma_sql_import_status div').css('height', '270px');
        $(this).attr('toggle', 'on');
        $(this).html('-');  // to minimize
    } else {
        Severity: Minor
        Found in resources/js/src/drag_drop_import.ts and 1 other location - About 50 mins to fix
        resources/js/src/drag_drop_import.ts on lines 372..376

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        $(document).on('click', '.pma_drop_result h2 .close', function () {
    $(this).parent('h2').parent('div').remove();
});
        Severity: Major
        Found in resources/js/src/drag_drop_import.ts and 2 other locations - About 50 mins to fix
        resources/js/src/database/events.ts on lines 633..635
        resources/js/src/database/routines.ts on lines 992..994

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status