Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
src/Advisory/Advisor.php

Summary

Maintainability
C
1 day
Test Coverage

File Advisor.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace PhpMyAdmin\Advisory;
Severity: Minor
Found in src/Advisory/Advisor.php - About 2 hrs to fix

    Method __construct has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(private DatabaseInterface $dbi, private ExpressionLanguage $expression)
    {
        /**
         * Register functions for ExpressionLanguage, we intentionally
         * do not implement support for compile as we do not use it.
    Severity: Major
    Found in src/Advisory/Advisor.php - About 2 hrs to fix

      Function runRules has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private function runRules(): void
    {
        $this->firedRules = [];
        $this->notFiredRules = [];
        $this->uncheckedRules = [];
      Severity: Minor
      Found in src/Advisory/Advisor.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method runRules has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function runRules(): void
    {
        $this->firedRules = [];
        $this->notFiredRules = [];
        $this->uncheckedRules = [];
      Severity: Major
      Found in src/Advisory/Advisor.php - About 2 hrs to fix

        Method addRule has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function addRule(string $type, array $rule): void
    {
        if ($type === 'unchecked') {
            $this->uncheckedRules[] = $rule;
        Severity: Minor
        Found in src/Advisory/Advisor.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status