phpmyadmin/phpmyadmin

View on GitHub
src/Config/ServerConfigChecks.php

Summary

Maintainability
D
1 day
Test Coverage

File ServerConfigChecks.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Server config checks management
 */

Severity: Minor
Found in src/Config/ServerConfigChecks.php - About 4 hrs to fix

    Method performConfigChecksServers has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function performConfigChecksServers(string $blowfishSecret): void
        {
            $blowfishSecretSet = false;
    
            $serverCnt = $this->cfg->getServerCount();
    Severity: Major
    Found in src/Config/ServerConfigChecks.php - About 3 hrs to fix

      Method performConfigChecksLoginCookie has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function performConfigChecksLoginCookie(): void
          {
              // $cfg['LoginCookieValidity']
              // value greater than session.gc_maxlifetime will cause
              // random session invalidation after that time
      Severity: Major
      Found in src/Config/ServerConfigChecks.php - About 2 hrs to fix

        Method performConfigChecks has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function performConfigChecks(): void
            {
                /** @var string $blowfishSecret */
                $blowfishSecret = $this->cfg->get('blowfish_secret', '');
        
        
        Severity: Minor
        Found in src/Config/ServerConfigChecks.php - About 1 hr to fix

          Function performConfigChecksServers has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function performConfigChecksServers(string $blowfishSecret): void
              {
                  $blowfishSecretSet = false;
          
                  $serverCnt = $this->cfg->getServerCount();
          Severity: Minor
          Found in src/Config/ServerConfigChecks.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method performConfigChecksServersZipdump has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function performConfigChecksServersZipdump(): void
              {
                  // $cfg['ZipDump']
                  // requires zip_open in import
                  if ($this->cfg->getValue('ZipDump') && ! $this->functionExists('zip_open')) {
          Severity: Minor
          Found in src/Config/ServerConfigChecks.php - About 1 hr to fix

            There are no issues that match your filters.

            Category
            Status