Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
src/Config/Settings.php

Summary

Maintainability
F
1 wk
Test Coverage

File Settings.php has 2193 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace PhpMyAdmin\Config;
Severity: Major
Found in src/Config/Settings.php - About 6 days to fix

    Settings has 194 functions (exceeds 20 allowed). Consider refactoring.
    Open

    final class Settings
{
    /**
     * Your phpMyAdmin URL.
     *
    Severity: Major
    Found in src/Config/Settings.php - About 3 days to fix

      Method asArray has 194 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function asArray(): array
    {
        return [
            'PmaAbsoluteUri' => $this->PmaAbsoluteUri,
            'AuthLog' => $this->authLog,
      Severity: Major
      Found in src/Config/Settings.php - About 7 hrs to fix

        Method __construct has 192 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(array $settings)
    {
        $this->PmaAbsoluteUri = $this->setPmaAbsoluteUri($settings);
        $this->authLog = $this->setAuthLog($settings);
        $this->authLogSuccess = $this->setAuthLogSuccess($settings);
        Severity: Major
        Found in src/Config/Settings.php - About 7 hrs to fix

          Method setAvailableCharsets has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function setAvailableCharsets(array $settings): array
    {
        if (! isset($settings['AvailableCharsets']) || ! is_array($settings['AvailableCharsets'])) {
            return [
                'iso-8859-1',
          Severity: Minor
          Found in src/Config/Settings.php - About 1 hr to fix

            Function setServers has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                private function setServers(array $settings): array
    {
        if (! isset($settings['Servers']) || ! is_array($settings['Servers'])) {
            return [1 => new Server()];
        }
            Severity: Minor
            Found in src/Config/Settings.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return '__';
            Severity: Major
            Found in src/Config/Settings.php - About 30 mins to fix

              Function setNavigationTreeTableSeparator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setNavigationTreeTableSeparator(array $settings): false|string|array
    {
        if (! isset($settings['NavigationTreeTableSeparator'])) {
            return '__';
        }
              Severity: Minor
              Found in src/Config/Settings.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setTrustedProxies has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setTrustedProxies(array $settings): array
    {
        if (! isset($settings['TrustedProxies']) || ! is_array($settings['TrustedProxies'])) {
            return [];
        }
              Severity: Minor
              Found in src/Config/Settings.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setDefaultFunctions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setDefaultFunctions(array $settings): array
    {
        if (! isset($settings['DefaultFunctions']) || ! is_array($settings['DefaultFunctions'])) {
            return [
                'FUNC_CHAR' => '',
              Severity: Minor
              Found in src/Config/Settings.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setMysqlSslWarningSafeHosts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setMysqlSslWarningSafeHosts(array $settings): array
    {
        if (! isset($settings['MysqlSslWarningSafeHosts']) || ! is_array($settings['MysqlSslWarningSafeHosts'])) {
            return ['127.0.0.1', 'localhost'];
        }
              Severity: Minor
              Found in src/Config/Settings.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          return [
                'iso-8859-1',
                'iso-8859-2',
                'iso-8859-3',
                'iso-8859-4',
              Severity: Major
              Found in src/Config/Settings.php and 1 other location - About 1 hr to fix
              src/Replication/ReplicationInfo.php on lines 18..52

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 101.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status