Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
src/ConfigStorage/UserGroups.php

Summary

Maintainability
C
1 day
Test Coverage

Method getHtmlToEditUserGroup has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getHtmlToEditUserGroup(
        ConfigurableMenusFeature $configurableMenusFeature,
        string|null $userGroup = null,
    ): string {
        $urlParams = [];
Severity: Major
Found in src/ConfigStorage/UserGroups.php - About 2 hrs to fix

    Function getHtmlToEditUserGroup has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getHtmlToEditUserGroup(
        ConfigurableMenusFeature $configurableMenusFeature,
        string|null $userGroup = null,
    ): string {
        $urlParams = [];
    Severity: Minor
    Found in src/ConfigStorage/UserGroups.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getHtmlForUserGroupsTable has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function getHtmlForUserGroupsTable(ConfigurableMenusFeature $configurableMenusFeature): string
    {
        $groupTable = Util::backquote($configurableMenusFeature->database)
            . '.' . Util::backquote($configurableMenusFeature->userGroups);
        $sqlQuery = 'SELECT * FROM ' . $groupTable . ' ORDER BY `usergroup` ASC';
    Severity: Minor
    Found in src/ConfigStorage/UserGroups.php - About 2 hrs to fix

      Method edit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function edit(
        ConfigurableMenusFeature $configurableMenusFeature,
        string $userGroup,
        bool $new = false,
    ): void {
      Severity: Minor
      Found in src/ConfigStorage/UserGroups.php - About 1 hr to fix

        Function getHtmlForUserGroupsTable has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getHtmlForUserGroupsTable(ConfigurableMenusFeature $configurableMenusFeature): string
    {
        $groupTable = Util::backquote($configurableMenusFeature->database)
            . '.' . Util::backquote($configurableMenusFeature->userGroups);
        $sqlQuery = 'SELECT * FROM ' . $groupTable . ' ORDER BY `usergroup` ASC';
        Severity: Minor
        Found in src/ConfigStorage/UserGroups.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function edit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function edit(
        ConfigurableMenusFeature $configurableMenusFeature,
        string $userGroup,
        bool $new = false,
    ): void {
        Severity: Minor
        Found in src/ConfigStorage/UserGroups.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status