Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
src/CreateAddField.php

Summary

Maintainability
D
1 day
Test Coverage

File CreateAddField.php has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace PhpMyAdmin;
Severity: Minor
Found in src/CreateAddField.php - About 2 hrs to fix

    Function getPartitionDefinition has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getPartitionDefinition(
        array $partition,
        bool $isSubPartition = false,
    ): string {
        $sqlQuery = ' ' . ($isSubPartition ? 'SUB' : '') . 'PARTITION ';
    Severity: Minor
    Found in src/CreateAddField.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getPartitionDefinition has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getPartitionDefinition(
        array $partition,
        bool $isSubPartition = false,
    ): string {
        $sqlQuery = ' ' . ($isSubPartition ? 'SUB' : '') . 'PARTITION ';
    Severity: Minor
    Found in src/CreateAddField.php - About 1 hr to fix

      Function buildIndexStatement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildIndexStatement(
        array $index,
        string $indexChoice,
        bool $isCreateTable = true,
    ): string {
      Severity: Minor
      Found in src/CreateAddField.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildIndexStatement has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function buildIndexStatement(
        array $index,
        string $indexChoice,
        bool $isCreateTable = true,
    ): string {
      Severity: Minor
      Found in src/CreateAddField.php - About 1 hr to fix

        Method getColumnCreationStatements has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getColumnCreationStatements(bool $isCreateTable = true): string
    {
        $sqlStatement = '';
        [
            $fieldCount,
        Severity: Minor
        Found in src/CreateAddField.php - About 1 hr to fix

          Method getPartitionsDefinition has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getPartitionsDefinition(): string
    {
        $sqlQuery = '';
        if (
            ! empty($_POST['partition_by'])
          Severity: Minor
          Found in src/CreateAddField.php - About 1 hr to fix

            Method getTableCreationQuery has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getTableCreationQuery(string $db, string $table): string
    {
        // get column addition statements
        $sqlStatement = $this->getColumnCreationStatements();
            Severity: Minor
            Found in src/CreateAddField.php - About 1 hr to fix

              Function setColumnCreationStatementSuffix has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setColumnCreationStatementSuffix(
        int $previousField,
        bool $isCreateTable = true,
    ): string {
        // no suffix is needed if request is a table creation
              Severity: Minor
              Found in src/CreateAddField.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                          return ' ';
              Severity: Major
              Found in src/CreateAddField.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return ' AFTER ' . Util::backquote($_POST['field_name'][$previousField]);
                Severity: Major
                Found in src/CreateAddField.php - About 30 mins to fix

                  Function getPartitionsDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getPartitionsDefinition(): string
    {
        $sqlQuery = '';
        if (
            ! empty($_POST['partition_by'])
                  Severity: Minor
                  Found in src/CreateAddField.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getColumnCreationStatements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function getColumnCreationStatements(bool $isCreateTable = true): string
    {
        $sqlStatement = '';
        [
            $fieldCount,
                  Severity: Minor
                  Found in src/CreateAddField.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (
            ! empty($_POST['partition_by'])
            && ! empty($_POST['partition_expr'])
            && ! empty($_POST['partition_count'])
            && $_POST['partition_count'] > 1
                  Severity: Minor
                  Found in src/CreateAddField.php and 1 other location - About 35 mins to fix
                  src/CreateAddField.php on lines 276..285

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 92.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (
            ! empty($_POST['subpartition_by'])
            && ! empty($_POST['subpartition_expr'])
            && ! empty($_POST['subpartition_count'])
            && $_POST['subpartition_count'] > 1
                  Severity: Minor
                  Found in src/CreateAddField.php and 1 other location - About 35 mins to fix
                  src/CreateAddField.php on lines 265..274

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 92.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status