phpmyadmin/phpmyadmin

View on GitHub
src/Plugins/Export/ExportOdt.php

Summary

Maintainability
F
5 days
Test Coverage

File ExportOdt.php has 511 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Set of functions used to build OpenDocument Text dumps of tables
 */

Severity: Major
Found in src/Plugins/Export/ExportOdt.php - About 1 day to fix

    Function getTableDef has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getTableDef(
            string $db,
            string $table,
            bool $doRelation,
            bool $doComments,
    Severity: Minor
    Found in src/Plugins/Export/ExportOdt.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getTableDef has 114 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getTableDef(
            string $db,
            string $table,
            bool $doRelation,
            bool $doComments,
    Severity: Major
    Found in src/Plugins/Export/ExportOdt.php - About 4 hrs to fix

      Method exportData has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function exportData(
              string $db,
              string $table,
              string $errorUrl,
              string $sqlQuery,
      Severity: Major
      Found in src/Plugins/Export/ExportOdt.php - About 2 hrs to fix

        Method setProperties has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function setProperties(): ExportPluginProperties
            {
                $GLOBALS['plugin_param'] ??= null;
        
                $hideStructure = false;
        Severity: Major
        Found in src/Plugins/Export/ExportOdt.php - About 2 hrs to fix

          Function exportData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function exportData(
                  string $db,
                  string $table,
                  string $errorUrl,
                  string $sqlQuery,
          Severity: Minor
          Found in src/Plugins/Export/ExportOdt.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getTriggers has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getTriggers(string $table, array $triggers): string
              {
                  $GLOBALS['odt_buffer'] .= '<table:table'
                      . ' table:name="' . htmlspecialchars($table) . '_triggers">'
                      . '<table:table-column'
          Severity: Minor
          Found in src/Plugins/Export/ExportOdt.php - About 1 hr to fix

            Method exportStructure has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function exportStructure(
                    string $db,
                    string $table,
                    string $exportMode,
                    string $exportType,
            Severity: Minor
            Found in src/Plugins/Export/ExportOdt.php - About 1 hr to fix

              Method getTableDefStandIn has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getTableDefStandIn(string $db, string $view, array $aliases = []): string
                  {
                      $dbAlias = $db;
                      $viewAlias = $view;
                      $this->initAlias($aliases, $dbAlias, $viewAlias);
              Severity: Minor
              Found in src/Plugins/Export/ExportOdt.php - About 1 hr to fix

                Method exportStructure has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        string $db,
                        string $table,
                        string $exportMode,
                        string $exportType,
                        bool $doRelation = false,
                Severity: Major
                Found in src/Plugins/Export/ExportOdt.php - About 1 hr to fix

                  Method getTableDef has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          string $db,
                          string $table,
                          bool $doRelation,
                          bool $doComments,
                          bool $doMime,
                  Severity: Minor
                  Found in src/Plugins/Export/ExportOdt.php - About 45 mins to fix

                    Method exportData has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            string $db,
                            string $table,
                            string $errorUrl,
                            string $sqlQuery,
                            array $aliases = [],
                    Severity: Minor
                    Found in src/Plugins/Export/ExportOdt.php - About 35 mins to fix

                      Function setProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function setProperties(): ExportPluginProperties
                          {
                              $GLOBALS['plugin_param'] ??= null;
                      
                              $hideStructure = false;
                      Severity: Minor
                      Found in src/Plugins/Export/ExportOdt.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (isset($GLOBALS[$GLOBALS['what'] . '_columns'])) {
                                  $GLOBALS['odt_buffer'] .= '<table:table-row>';
                                  foreach ($fieldsMeta as $field) {
                                      $colAs = $field->name;
                                      if (! empty($aliases[$db]['tables'][$table]['columns'][$colAs])) {
                      Severity: Major
                      Found in src/Plugins/Export/ExportOdt.php and 1 other location - About 3 hrs to fix
                      src/Plugins/Export/ExportOds.php on lines 214..230

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 146.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              $GLOBALS['odt_buffer'] .= '<table:table-row>'
                                  . '<table:table-cell office:value-type="string">'
                                  . '<text:p>' . __('Column') . '</text:p>'
                                  . '</table:table-cell>'
                                  . '<table:table-cell office:value-type="string">'
                      Severity: Major
                      Found in src/Plugins/Export/ExportOdt.php and 1 other location - About 1 hr to fix
                      src/Plugins/Export/ExportOdt.php on lines 359..371

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 109.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              $GLOBALS['odt_buffer'] .= '<table:table-row>'
                                  . '<table:table-cell office:value-type="string">'
                                  . '<text:p>' . __('Column') . '</text:p>'
                                  . '</table:table-cell>'
                                  . '<table:table-cell office:value-type="string">'
                      Severity: Major
                      Found in src/Plugins/Export/ExportOdt.php and 1 other location - About 1 hr to fix
                      src/Plugins/Export/ExportOdt.php on lines 452..464

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 109.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status