Sign upLogin

phpmyadmin/phpmyadmin

View on GitHub
Star
src/Plugins/Schema/Eps/EpsRelationSchema.php

Summary

Maintainability
D
2 days
Test Coverage

Function __construct has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(Relation $relation, DatabaseName $db)
    {
        parent::__construct($relation, $db);

        $this->eps = new Eps();
Severity: Minor
Found in src/Plugins/Schema/Eps/EpsRelationSchema.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(Relation $relation, DatabaseName $db)
    {
        parent::__construct($relation, $db);

        $this->eps = new Eps();
Severity: Major
Found in src/Plugins/Schema/Eps/EpsRelationSchema.php - About 3 hrs to fix

    Method addRelation has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function addRelation(
        string $masterTable,
        string $font,
        int $fontSize,
        string $masterField,
    Severity: Minor
    Found in src/Plugins/Schema/Eps/EpsRelationSchema.php - About 1 hr to fix

      Method addRelation has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $masterTable,
        string $font,
        int $fontSize,
        string $masterField,
        string $foreignTable,
      Severity: Major
      Found in src/Plugins/Schema/Eps/EpsRelationSchema.php - About 50 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ($alltables as $oneTable) {
            $existRel = $this->relation->getForeigners($this->db->getName(), $oneTable);
            if ($existRel === []) {
                continue;
            }
        Severity: Major
        Found in src/Plugins/Schema/Eps/EpsRelationSchema.php and 1 other location - About 7 hrs to fix
        src/Plugins/Schema/Svg/SvgRelationSchema.php on lines 115..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 237.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (! isset($this->tables[$table])) {
                $this->tables[$table] = new TableStatsEps(
                    $this->eps,
                    $this->db->getName(),
                    $table,
        Severity: Major
        Found in src/Plugins/Schema/Eps/EpsRelationSchema.php and 1 other location - About 1 hr to fix
        src/Plugins/Schema/Svg/SvgRelationSchema.php on lines 84..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (! isset($this->tables[$masterTable])) {
            $this->tables[$masterTable] = new TableStatsEps(
                $this->eps,
                $this->db->getName(),
                $masterTable,
        Severity: Minor
        Found in src/Plugins/Schema/Eps/EpsRelationSchema.php and 1 other location - About 50 mins to fix
        src/Plugins/Schema/Eps/EpsRelationSchema.php on lines 201..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (! isset($this->tables[$foreignTable])) {
            $this->tables[$foreignTable] = new TableStatsEps(
                $this->eps,
                $this->db->getName(),
                $foreignTable,
        Severity: Minor
        Found in src/Plugins/Schema/Eps/EpsRelationSchema.php and 1 other location - About 50 mins to fix
        src/Plugins/Schema/Eps/EpsRelationSchema.php on lines 187..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status