phug-php/formatter

View on GitHub
Formatter/Partial/HandleVariable.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method isInExclusionContext has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function isInExclusionContext(&$tokens, $index)
    {
        foreach ([
            // Exclude tokens before the variables
            -1 => [
Severity: Major
Found in Formatter/Partial/HandleVariable.php - About 2 hrs to fix

    Function isInExclusionContext has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private function isInExclusionContext(&$tokens, $index)
        {
            foreach ([
                // Exclude tokens before the variables
                -1 => [
    Severity: Minor
    Found in Formatter/Partial/HandleVariable.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isInFunctionParams has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function isInFunctionParams(&$tokens, $index)
        {
            $afterOpen = false;
            for ($i = $index - 1; $i >= 0; $i--) {
                if (in_array($tokens[$i], [')', '}'], true)) {
    Severity: Minor
    Found in Formatter/Partial/HandleVariable.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (!$checked ||
                $this->isInExclusionContext($tokens, $index) ||
                $this->isInFunctionParams($tokens, $index) ||
                $this->isInKeywordParams($tokens, $index) ||
                $this->isInComplexInterpolation($tokens, $index) ||
    Severity: Major
    Found in Formatter/Partial/HandleVariable.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status