Sign upLogin

phug-php/phug

View on GitHub
Star

Showing 115 of 115 total issues

File AbstractFormat.php has 806 lines of code (exceeds 400 allowed). Consider refactoring.
Open

<?php

namespace Phug\Formatter;

use Phug\Formatter;
Severity: Major
Found in src/Phug/Formatter/Formatter/AbstractFormat.php - About 1 day to fix

    Function compileNode has a Cognitive Complexity of 41 (exceeds 7 allowed). Consider refactoring.
    Open

        public function compileNode(NodeInterface $node, ElementInterface $parent = null)
    {
        $compiler = $this->getCompiler();
        $compiler->assert(
            $node instanceof ImportNode,
    Severity: Minor
    Found in src/Phug/Compiler/Compiler/NodeCompiler/ImportNodeCompiler.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Phug\Lexer\Event;

use Phug\Event;
    Severity: Major
    Found in src/Phug/Lexer/Lexer/Event/LexEvent.php and 1 other location - About 5 hrs to fix
    src/Phug/Parser/Parser/Event/ParseEvent.php on lines 1..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 207.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Phug\Parser\Event;

use Phug\Event;
    Severity: Major
    Found in src/Phug/Parser/Parser/Event/ParseEvent.php and 1 other location - About 5 hrs to fix
    src/Phug/Lexer/Lexer/Event/LexEvent.php on lines 1..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 207.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File Compiler.php has 531 lines of code (exceeds 400 allowed). Consider refactoring.
    Open

    <?php

namespace Phug;

// Node compilers
    Severity: Major
    Found in src/Phug/Compiler/Compiler.php - About 5 hrs to fix

      Method formatMixinCallElement has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function formatMixinCallElement(MixinCallElement $mixinCall)
    {
        $hasBlock = $mixinCall->hasChildren();
        $children = new PhpUnwrap($this->formatElementChildren($mixinCall), $this->formatter);
        $mixinName = $mixinCall->getName();
      Severity: Major
      Found in src/Phug/Formatter/Formatter/AbstractFormat.php - About 4 hrs to fix

        Method compileNode has 103 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function compileNode(NodeInterface $node, ElementInterface $parent = null)
    {
        $compiler = $this->getCompiler();
        $compiler->assert(
            $node instanceof ImportNode,
        Severity: Major
        Found in src/Phug/Compiler/Compiler/NodeCompiler/ImportNodeCompiler.php - About 4 hrs to fix

          Reader has 42 functions (exceeds 30 allowed). Consider refactoring.
          Open

          class Reader
{
    use PathTrait;

    /**
          Severity: Minor
          Found in src/Phug/Reader/Reader.php - About 4 hrs to fix

            Compiler has 41 functions (exceeds 30 allowed). Consider refactoring.
            Open

            class Compiler implements ModuleContainerInterface, CompilerInterface, WithUpperLocatorInterface
{
    use ModuleContainerTrait;
    use YieldHandlerTrait;
            Severity: Minor
            Found in src/Phug/Compiler/Compiler.php - About 3 hrs to fix

              AbstractFormat has 40 functions (exceeds 30 allowed). Consider refactoring.
              Open

              abstract class AbstractFormat implements FormatInterface, OptionInterface
{
    use HandleVariable;
    use OptionTrait;
    use PatternTrait;
              Severity: Minor
              Found in src/Phug/Formatter/Formatter/AbstractFormat.php - About 3 hrs to fix

                Function getSourceLine has a Cognitive Complexity of 27 (exceeds 7 allowed). Consider refactoring.
                Open

                    private function getSourceLine($error)
    {
        $previous = null;
        $line = null;
                Severity: Minor
                Found in src/Phug/Formatter/Formatter.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Node has 39 functions (exceeds 30 allowed). Consider refactoring.
                Open

                class Node implements NodeInterface
{
    /**
     * Stores the current parent node of this node.
     *
                Severity: Minor
                Found in src/Phug/Ast/Ast/Node.php - About 3 hrs to fix

                  State has 39 functions (exceeds 30 allowed). Consider refactoring.
                  Open

                  class State implements OptionInterface, EventManagerInterface
{
    use OptionTrait;
    use EventManagerTrait;
                  Severity: Minor
                  Found in src/Phug/Parser/Parser/State.php - About 3 hrs to fix

                    Method __construct has 87 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function __construct($options = null)
    {
        $this->setOptionsDefaults($options ?: [], [
            'paths'                      => [],
            'debug'                      => false,
                    Severity: Major
                    Found in src/Phug/Compiler/Compiler.php - About 3 hrs to fix

                      Function readExpression has a Cognitive Complexity of 25 (exceeds 7 allowed). Consider refactoring.
                      Open

                          public function readExpression(array $breaks = null, array $brackets = null)
    {
        if (!$this->hasLength()) {
            return;
        }
                      Severity: Minor
                      Found in src/Phug/Reader/Reader.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method formatMixinElement has 79 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function formatMixinElement(MixinElement $mixin)
    {
        $mixinName = $mixin->getName();
        $name = is_string($mixinName)
            ? var_export($mixinName, true)
                      Severity: Major
                      Found in src/Phug/Formatter/Formatter/AbstractFormat.php - About 3 hrs to fix

                        Method __construct has 79 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function __construct($options = null)
    {
        $this->setOptionsDefaults($options ?: [], [
            'lexer_class_name'        => Lexer::class,
            'parser_state_class_name' => State::class,
                        Severity: Major
                        Found in src/Phug/Parser/Parser.php - About 3 hrs to fix

                          File XmlFormat.php has 448 lines of code (exceeds 400 allowed). Consider refactoring.
                          Open

                          <?php

namespace Phug\Formatter\Format;

use Closure;
                          Severity: Minor
                          Found in src/Phug/Formatter/Formatter/Format/XmlFormat.php - About 3 hrs to fix

                            Method __construct has 73 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function __construct(Formatter $formatter = null)
    {
        $patterns = [
            'class_attribute'        => static::CLASS_ATTRIBUTE,
            'string_attribute'       => static::STRING_ATTRIBUTE,
                            Severity: Major
                            Found in src/Phug/Formatter/Formatter/AbstractFormat.php - About 2 hrs to fix

                              Method yieldAssignmentElement has 70 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  protected function yieldAssignmentElement(AssignmentElement $element)
    {
        foreach ($this->getOption('assignment_handlers') as $handler) {
            $iterator = $handler($element) ?: [];
                              Severity: Major
                              Found in src/Phug/Formatter/Formatter/Format/XmlFormat.php - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language