Function getVersion
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
public function getVersion($version, $stable)
{
if (!is_string($version)) {
throw new \InvalidArgumentException('Unexpected value, string expected!');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function retrieveVersions
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
protected function retrieveVersions()
{
if ($this->versions === null) {
$repository = escapeshellarg($this->joomlaRepository);
$result = `git ls-remote $repository | grep -E 'refs/(tags|heads)' | grep -v '{}'`;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getVersion
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getVersion($version, $stable)
{
if (!is_string($version)) {
throw new \InvalidArgumentException('Unexpected value, string expected!');
}
Function retrieveVersionsFromCache
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function retrieveVersionsFromCache()
{
// check if file exists and is new enough
if ($this->cachePath && file_exists($this->cachePath)) {
if (filemtime($this->cachePath) < (time() - $this->cacheExpire)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return null;